-
Notifications
You must be signed in to change notification settings - Fork 37
SRU docs added to navig. structure #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* SRU explanation & reference articles added to
How Ubuntu is made -> Process overviews
* SRU howto articles added to
Contributors -> Stable Release Updates (SRU)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two things I've spotted, both non-blocking and can be fixed in a follow-up:
- In
SRU/stable-release-updatesandSRU/explanation/pipelinethe diagrams don't render. - In
SRU/reference/package-specificthere are multiple h1-level headers which introduces extra noise into the navigation menu. Not sure if the original intention was for them to be surfaced at the top level (implying they should be on different pages) or if they should indeed be subsections under the "package specific notes" page (implying they should be h2-level).
That's weird. It works ok on local :/ Looking into it.
I believe that's intentional. Those are indeed independent pages. |
ef33607 to
6e975da
Compare
6e975da to
da86159
Compare
Fixed. Thanks for the heads up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Description
This PR adds the imported (#228) SRU docs into the navig. structure of the Project docs while mostly preserving the structure of the orig. docs set.
The only change is that the landing page for SRU explanation articles was merged with the SRU docs main landing page. This new landing page is now found at "How Ubuntu is made -> Process overviews -> Stable Release Updates (SRU)".
A link to an existing intro article (Introduction to SRU) was also added to the landing page for the howto articles: "Contributors -> Stable Release Updates".
Preview build: https://canonical-ubuntu-documentation-library--253.com.readthedocs.build/project/
Next steps
Following the merging of this PR, redirects will be put in place from the orig. docs set, so that all existing links and bookmarks pointing to the docs at documentation.ubuntu.com/sru would continue to work.
Checklist
Additional notes
@basak, your invitation to the repo is still pending, so the CODEOWNERS system is not automatically triggering a review request for you. If you add a comment to the PR, I should be able to request a review from you manually.