MIR: request to think about impact elsewhere #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
cpaelzer
requested review from
MylesJP,
didrocks,
joalif,
pushkarnk,
setharnold and
slyon
as code owners
setharnold
requested changes
Nov 14, 2025
Collaborator
setharnold
left a comment
setharnold
left a comment
There was a problem hiding this comment.
One nitpick, feel free to merge with a fix.
| RULE: sympathy available. | ||
| RULE: Examples of the past which we admit could have been better (grows by | ||
| RULE: painful lessons learned): | ||
| RULE: - changing to rust coreutils forced us to update any appamore profiles |
Collaborator
There was a problem hiding this comment.
appamore is a lovely name :) but not quite right, hehe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed we'd want the reporter to think for a moment which other teams this might impact and call them for coordination - if possible upfront. We concluded that we can not make a perfect description and instead start with an example to be extended as we go along.