Mir help reference rules #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-makin
approved these changes
Jun 20, 2025
Collaborator
s-makin
left a comment
s-makin
left a comment
There was a problem hiding this comment.
Generally LGTM, just one quick question
Collaborator
Author
|
About the automated checks, I change no spelling, no language and no link - hence this is in other existing content. |
s-makin
approved these changes
Jun 20, 2025
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
The platform does not allow the :lineanchors: option yet, but this is quite nice already. This way each line gets prepended by a line number automatically. These line numbers can be used to say on this link (now only one template per linke) and say, look at line number X. Once :lineanchors: works that can even allow deep links in the future. Nice is also that the copy and paste feature does not include the numbers, so it is not making the reporter or reviewer life harder. Fixes ubuntu#40 Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
cpaelzer
force-pushed
the
mir-help-reference-rules
branch
from
9c1f928 to
5e80228
Compare
Collaborator
Author
|
FYI - rebased for other changes landing in the meantime |
Collaborator
This is known and on me to fix 😅 |
Collaborator
Author
|
I think we are goo until another MIR member had a look and then we can merge |
slyon
approved these changes
Jun 23, 2025
Collaborator
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
LGTM!
With a small nitpick inline, that I don't know how to fix, but shouldn't be blocking this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #40 we recently split the page (one URL per template) and this now adds line numbers.