Address a lint warning in PAM / NSS about regcomp return value check (#309)

jonasbardino · web-flow · commit 9a6d02549d38 · 2025-08-07T09:01:08.000+02:00
Address a lint warning in PAM / NSS that regcomp int return value is
used as bool. Non-zero value means error according to `man regcomp`.
diff --git a/mig/src/include/auth/migauth.h b/mig/src/include/auth/migauth.h
@@ -416,7 +416,8 @@ static int validate_username(const char *username)
     }
 
     regex_res = regcomp(&validator, username_regex, REG_EXTENDED | REG_NOSUB);
-    if (regex_res) {
+    if (regex_res != 0) {
+        /* Failure in regex compilation */
         if (regex_res == REG_ESPACE) {
             WRITELOGMESSAGE(LOG_ERR,
                             "Memory error in username validation: %s\n",

Original file line number	Diff line number	Diff line change
`@@ -416,7 +416,8 @@ static int validate_username(const char *username)`
`416`	`416`	`}`
`417`	`417`
`418`	`418`	`regex_res = regcomp(&validator, username_regex, REG_EXTENDED \| REG_NOSUB);`
`419`		`- if (regex_res) {`
	`419`	`+ if (regex_res != 0) {`
	`420`	`+ /* Failure in regex compilation */`
`420`	`421`	`if (regex_res == REG_ESPACE) {`
`421`	`422`	`WRITELOGMESSAGE(LOG_ERR,`
`422`	`423`	`"Memory error in username validation: %s\n",`