Unit tests to cover most of mig/shared/base.py

[jonasbardino]

Unit tests wrapping existing self-tests and most of the helper functions.

While building the test suite I discovered some corner cases that we currently don't support all that well. The corresponding tests are therefore left disabled but marked with TODO for follow-up.

[albu-diku]

This looks good to me - I would however suggest renaming the PR. The current title reads like a generic facility which isn't quite auccrate - somethin like: "Fundamental test coverage of mig/shared/basic". The in the description:
"Wire the legacy unit tests into the automated suite and fill coverge gaps with addition test cases."

[albu-diku]

I have approved these changes as the code itself looks good - but I have made some suggestions about the PR title and description that I think would clarify what is here in case it is referred to in future: #366 (comment)

I think it may also be preferable to squash the work here down to a single commit at the point of landing it for clarity.

[jonasbardino]

This looks good to me - I would however suggest renaming the PR. The current title reads like a generic facility which isn't quite auccrate - somethin like: "Fundamental test coverage of mig/shared/basic". The in the description: "Wire the legacy unit tests into the automated suite and fill coverge gaps with addition test cases."

Thanks for the review. Yes, the title had indeed been left behind from the original commit. Updated now.
Note to self: when making a PR from a single commit one should double check if the git commit log suggested for title/description includes enough information or if e.g. relevant file info was left out as redundant there.

[jonasbardino]

I have approved these changes as the code itself looks good - but I have made some suggestions about the PR title and description that I think would clarify what is here in case it is referred to in future: #366 (comment)

I think it may also be preferable to squash the work here down to a single commit at the point of landing it for clarity.

Addressed the first bit above, and good point about simplifying on merge. I'll give squash merge a try.