Skip to content

Improved unit test coverage of mig lib janitor #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 12, 2025
Merged

Improved unit test coverage of mig lib janitor #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9dbfe66
Significantly extend coverage of janitor to fundamentally test all fu…
jonasbardino Oct 21, 2025
50a5316
Remove debug prints.
jonasbardino Oct 21, 2025
1ed1573
Extend test coverage further to approach complete coverage:
jonasbardino Oct 21, 2025
d540a6f
Increase test coverage with additional scenarios like:
jonasbardino Oct 21, 2025
8fa830f
Enable session-cleanup timestamp check now that the corresponding cop…
jonasbardino Oct 21, 2025
d627de7
Switch completely to testconfig provisioning including `self.configur…
jonasbardino Oct 21, 2025
ec81f41
Just a TODO about a corner case crash we may potentially hit if a pw …
jonasbardino Oct 21, 2025
f0de0b3
Switch to self._provision_test_user instead of DB dump in response to…
jonasbardino Oct 21, 2025
1435067
Expand coverage a bit and change SkipIf TODOs to one-liners.
jonasbardino Nov 9, 2025
1857e0c
Rework janitor tests to rely on a shared state file init helper to cr…
jonasbardino Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mig/lib/janitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
#!/usr/bin/python
# -*- coding: utf-8 -*-
#
Expand Down Expand Up @@ -56,7 +56,7 @@
SECS_PER_HOUR = 60 * SECS_PER_MINUTE
SECS_PER_DAY = 24 * SECS_PER_HOUR

task_triggers = {}

Check failure on line 59 in mig/lib/janitor.py

View workflow job for this annotation

GitHub Actions / Style check python and annotate 

Need type annotation for "task_triggers" (hint: "task_triggers: Dict[<type>, <type>] = ...")  [var-annotated]


def _lookup_last_run(configuration, target):
Expand Down Expand Up @@ -287,6 +287,8 @@
else:
_logger.info("rejected invalid %r account request" % client_id)
elif reset_token:
# TODO: handle loaded user_dict == None here (e.g. recently removed)
# to avoid verify_reset_token failing on DN access.
valid_reset = verify_reset_token(
configuration, user_dict, reset_token, req_auth, req_timestamp
)
Expand Down
Loading