migcheckssl: Enable error handling #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasbardino
reviewed
Nov 3, 2025
jonasbardino
reviewed
Nov 3, 2025
Contributor
jonasbardino
left a comment
jonasbardino
left a comment
There was a problem hiding this comment.
I think it's okay to disable the strict exit code checks here as we talked about off-list, but would really like to address the point I just added in my comment.
Namely, I've made a PR #383 to adjust the comments in all templates and suggest that you pull in something like the version in the similar migverifyarchives cronjob here before I approve.
jonasbardino
approved these changes
Nov 3, 2025
Contributor
jonasbardino
left a comment
jonasbardino
left a comment
There was a problem hiding this comment.
Thanks for adjusting.
jonasbardino
added a commit
that referenced
this pull request
Nov 3, 2025
… strategy in relation to PR382 (#383) Comment-only change to cronjobs to clarify our general error checking strategy and explain why we sometimes choose to deviate from it. Tries to capture the central points from a longer internal discussion in relation to issue #381 and the fix in PR #382. Adds the missing fixture for the existing miglustrequota cronjob.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migcheckssl fails to handle subscript errors which result in abnormal exist when checking for running services.
FIxes issue #381