Update GFS_debug (GFS_interstitialtoscreen) #310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Update
GFS_debug
schemes: removeGFS_interstitialtoscreen_timestep_init
andGFS_interstitialtoscreen_init
. These schemes never made sense, because the contents of the GFS interstitial DDTs aren't valid for these phases (only valid for therun
phase).Further, with the upcoming changes by @dustinswales that change when and how
GFS_interstitial
is allocated (triggered by ccpp-framework changes), they would create segmentation faults.Tests Conducted:
There is currently on regression test in the ufs-weather-model that exercises the
GFS_debug
schemes.I modified the
control_p8_intel
test to run theGFS_debug
schemes as follows:I ran this test with
-DDEBUG=ON
and saved the run directory on Ursa in a different path to show that the run completed successfully (out
) and that theGFS_debug
output is written toerr
as expected:/scratch4/NCEPDEV/stmp/Dom.Heinzeller/RT_RUNDIRS_KEEP_ufspr2880
The failing GitHub actions tests have nothing to do with my changes.
This PR was also tested with NOAA-EMC/ufsatm#1004 and ufs-community/ufs-weather-model#2880.
Dependencies:
n/a
Documentation:
n/a
Issue (optional):
n/a
Contributors (optional):
n/a