Reduce "Explicit interface or EXTERNAL declaration is required" compiler warnings in sfcsub #312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Compiling ufs-weather-model cpld_debug_gfsv17 RT gives a number of warnings in sfcsub for these variables:
Enclosing the whole file in the module resolves many of these, except
BAOPENR ABORT GETGBH GETGB SPLAT W3MOVDAT W3DOXDAT BACLOSE
as these come from elsewhere (like NCEPLIBS or compiler). So, I tried addingexternal
declaration for the rest.For W3MOVDAT, W3DOXDAT external doesn't resolve the warning, maybe since they have dimension(8) argument. I see some previous work to deal with w3emc NCAR#1070 but don't know if there were any decisions
Tests Conducted:
cpld_debug_gfsv17 is bit-for-bit on Ursa and most compiler warnings are resolved.
TODO: "See ufs-community/ufs-weather-model#<pr_number>"
Dependencies:
TODO: parent PRs. For example:
Documentation:
N/A
Issue (optional):
Part of ufs-community/ufs-weather-model#2703 to reduce compiler warnings in GFS.v17 for operational implementation
Contributors (optional):
N/A