Skip to content

Conversation

NickSzapiro-NOAA
Copy link

@NickSzapiro-NOAA NickSzapiro-NOAA commented Sep 10, 2025

Description of Changes:

Compiling ufs-weather-model cpld_debug_gfsv17 RT gives a number of warnings in sfcsub for these variables:

.../ufs-weather-model/UFSATM/ccpp/physics/physics/Interstitials/UFS_SCM_NEPTUNE/sfcsub.F(line): warning #8889: Explicit interface or EXTERNAL declaration is required.
HMSKRD FIXRDC ROF01 QCMXICE CLIMA SCALE ALBOCN LANDTYP ROF01_LEN QCSICE SETLSI QCSNOW SETZRO QCMXMN GETSCV SNOSFC GETSMC GETSTC MONITR FILANL ANALY ANOMINT TSFCOR SNODPTH2 FILFCS USESGT QCSLI QCBYFC NEWICE FIXRDG ABORT BAOPENR ABORT GETGBH GETGB FIXRDA SPLAT GA2LA FIXRDC_TILE NETCDF_ERR GETAREA SUBST SETRMSK BACLOSE LA2GA

Enclosing the whole file in the module resolves many of these, except BAOPENR ABORT GETGBH GETGB SPLAT W3MOVDAT W3DOXDAT BACLOSE as these come from elsewhere (like NCEPLIBS or compiler). So, I tried adding external declaration for the rest.

For W3MOVDAT, W3DOXDAT external doesn't resolve the warning, maybe since they have dimension(8) argument. I see some previous work to deal with w3emc NCAR#1070 but don't know if there were any decisions

Tests Conducted:

cpld_debug_gfsv17 is bit-for-bit on Ursa and most compiler warnings are resolved.
TODO: "See ufs-community/ufs-weather-model#<pr_number>"

Dependencies:

TODO: parent PRs. For example:

  • NCAR/ccpp-framework#<pr_number>
  • NOAA-EMC/fv3atm#<pr_number>
  • ufs-community/ufs-weather-model/#<pr_number>

Documentation:

N/A

Issue (optional):

Part of ufs-community/ufs-weather-model#2703 to reduce compiler warnings in GFS.v17 for operational implementation

Contributors (optional):

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant