Skip to content

Conversation

maddenp-cu
Copy link
Collaborator

Synopsis

The template_values item under namelist for schism and ww3 is optional per those drivers' schemas (and based on user feedback, this is a good thing, in that they might like to provide a complete, ready-to-use file via the template_file value and not apply any Jinja2 evaluation to it), but access in the driver code is via [] lookup, making them de facto required. Change [] lookups to .get() with a {} default value.

Type

  • Bug fix (corrects a known issue)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@maddenp-cu maddenp-cu merged commit 4b25355 into ufs-community:main Aug 7, 2024
@maddenp-cu maddenp-cu deleted the optional-schism-template-values branch August 7, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants