Skip to content

Conversation

christinaholtNOAA
Copy link
Collaborator

Synopsis

Fixes a bug associated with using the Rocoto streq dependency. When specifying the schema-approved YAML option for the dependency as in this very abbreviated example:

rocoto:
  task:
    dependency:
      streq:
        left: foo
        right: bar

The resulting XML is invalid against the Rocoto RelaxNG schema:

<streq/>

And should appear as:

<streq/>
  <left>foo</left>
  <right>bar</right>
<streq/>

To fix future instances of similar failures, I added validation checks to each config object used to test the rocoto mechanics.

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation
  • Enhancement (adds new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a breaking change (changes existing functionality)
  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@christinaholtNOAA christinaholtNOAA merged commit c00a82d into ufs-community:main Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants