fix(attribute): Move HasDisabled trait to UIAwesome\Html\Attribute namespace and update related imports accordingly.#76
Conversation
…` namespace and update related imports accordingly.
📝 WalkthroughSummary by CodeRabbit
WalkthroughMoved the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2026-01-09T16:05:15.502ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
🔇 Additional comments (2)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/Provider/DisabledProvider.php (1)
5-9:⚠️ Potential issue | 🟡 MinorUpdate docblock reference to new test namespace.
The
@seetarget still points toUIAwesome\Html\Attribute\Tests\Form\HasDisabledTest, which no longer exists after the namespace move.Proposed fix
- * Data provider for {`@see` \UIAwesome\Html\Attribute\Tests\Form\HasDisabledTest} test cases. + * Data provider for {`@see` \UIAwesome\Html\Attribute\Tests\HasDisabledTest} test cases.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (4)
CHANGELOG.mdsrc/HasDisabled.phptests/HasDisabledTest.phptests/Provider/DisabledProvider.php
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: terabytesoftw
Repo: ui-awesome/html-attribute PR: 18
File: tests/Support/Provider/Global/ContentEditableProvider.php:32-33
Timestamp: 2026-01-09T16:05:25.443Z
Learning: In the ui-awesome/html-attribute repository, when files are moved from the ui-awesome/html-core package (or other packages), the original copyright year in the file headers should be preserved rather than updated to the current year, as these represent the year the code was originally created.
📚 Learning: 2026-01-09T16:05:15.502Z
Learnt from: terabytesoftw
Repo: ui-awesome/html-attribute PR: 18
File: tests/Support/Provider/Global/ContentEditableProvider.php:32-33
Timestamp: 2026-01-09T16:05:15.502Z
Learning: Preserve the original copyright year in file headers when moving PHP source files between packages within the ui-awesome repositories (e.g., from ui-awesome/html-core to ui-awesome/html-attribute). Do not update the header year to the current year; keep the original creation year as stated in the header. This applies to all PHP files throughout the repo that are moved between packages.
Applied to files:
src/HasDisabled.phptests/HasDisabledTest.phptests/Provider/DisabledProvider.php
📚 Learning: 2026-01-09T16:05:25.443Z
Learnt from: terabytesoftw
Repo: ui-awesome/html-attribute PR: 18
File: tests/Support/Provider/Global/ContentEditableProvider.php:32-33
Timestamp: 2026-01-09T16:05:25.443Z
Learning: In the ui-awesome/html-attribute repository, when files are moved from the ui-awesome/html-core package (or other packages), the original copyright year in the file headers should be preserved rather than updated to the current year, as these represent the year the code was originally created.
Applied to files:
CHANGELOG.md
🧬 Code graph analysis (1)
tests/HasDisabledTest.php (1)
tests/Provider/DisabledProvider.php (1)
DisabledProvider(15-60)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: mutation / PHP 8.5-ubuntu-latest
- GitHub Check: easy-coding-standard / PHP 8.5-ubuntu-latest
- GitHub Check: phpunit / PHP 8.2-windows-2022
- GitHub Check: phpstan / PHP 8.5-ubuntu-latest
- GitHub Check: phpunit / PHP 8.3-windows-2022
- GitHub Check: phpunit / PHP 8.1-windows-2022
- GitHub Check: composer-require-checker / PHP 8.5-ubuntu-latest
- GitHub Check: linter / Super Linter
- GitHub Check: phpunit / PHP 8.4-windows-2022
- GitHub Check: linter / Super Linter
🔇 Additional comments (3)
CHANGELOG.md (1)
49-49: Changelog entry aligns with the namespace move.Looks correct and consistent with the PR scope.
src/HasDisabled.php (1)
5-7: Namespace update looks consistent.No functional changes; aligns with the trait relocation.
tests/HasDisabledTest.php (1)
5-10: Test namespace/import updates are correct.Imports now match the relocated trait and provider.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Pull Request