Skip to content

Commit 82fd447

Browse files
jaywcjlovejaywcjlove
committed
fix: default shouldExpandNodeInitially to false for collapsed nodes. #59 #76 87a29ec 
1 parent 9b4b997 commit 82fd447

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

77 files changed

+217
-205
lines changed

‎asset-manifest.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
{
22
"files": {
33
"main.css": "/static/css/main.7ea575dc.css",
4-
"main.js": "/static/js/main.fb0b21a8.js",
4+
"main.js": "/static/js/main.44e40c98.js",
55
"refractor-prismjs-vendor.0abbb2f3.js": "/static/js/refractor-prismjs-vendor.0abbb2f3.00343fb8.js",
66
"react-vendor.js": "/static/js/react-vendor.5bec418d.js",
77
"refractor-prismjs-vendor.3665b250.js": "/static/js/refractor-prismjs-vendor.3665b250.53b94c40.js",
88
"refractor-prismjs-vendor.a81a7d65.js": "/static/js/refractor-prismjs-vendor.a81a7d65.3c62cc2b.js",
99
"index.html": "/index.html",
1010
"main.7ea575dc.css.map": "/static/css/main.7ea575dc.css.map",
11-
"main.fb0b21a8.js.map": "/static/js/main.fb0b21a8.js.map",
11+
"main.44e40c98.js.map": "/static/js/main.44e40c98.js.map",
1212
"refractor-prismjs-vendor.0abbb2f3.00343fb8.js.map": "/static/js/refractor-prismjs-vendor.0abbb2f3.00343fb8.js.map",
1313
"react-vendor.5bec418d.js.map": "/static/js/react-vendor.5bec418d.js.map",
1414
"refractor-prismjs-vendor.3665b250.53b94c40.js.map": "/static/js/refractor-prismjs-vendor.3665b250.53b94c40.js.map",
@@ -20,6 +20,6 @@
2020
"static/js/refractor-prismjs-vendor.0abbb2f3.00343fb8.js",
2121
"static/js/react-vendor.5bec418d.js",
2222
"static/css/main.7ea575dc.css",
23-
"static/js/main.fb0b21a8.js"
23+
"static/js/main.44e40c98.js"
2424
]
2525
}

‎badges.svg‎

Lines changed: 8 additions & 8 deletions
Loading

‎index.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<!doctype html><html lang="en"><head><meta charset="utf-8"><meta name="viewport" content="width=device-width,initial-scale=1,shrink-to-fit=no"><meta name="theme-color" content="#000000"><meta name="keywords" content="react,react-component,array-viewer,base-16,component,interactive,interactive-json,json,json-component,json-display,json-tree,json-view,json-viewer,json-inspector,json-tree,react,react-component,react-json,theme,tree,tree-view,treeview,jaywcjlove"><meta name="description" content="A React component for displaying and editing javascript arrays and JSON objects."><link rel="shortcut icon" href="/favicon.ico"><title>react-json-view</title><script defer="defer" src="./static/js/refractor-prismjs-vendor.3665b250.53b94c40.js"></script><script defer="defer" src="./static/js/refractor-prismjs-vendor.a81a7d65.3c62cc2b.js"></script><script defer="defer" src="./static/js/refractor-prismjs-vendor.0abbb2f3.00343fb8.js"></script><script defer="defer" src="./static/js/react-vendor.5bec418d.js"></script><script defer="defer" src="./static/js/main.fb0b21a8.js"></script><link href="./static/css/main.7ea575dc.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>
1+
<!doctype html><html lang="en"><head><meta charset="utf-8"><meta name="viewport" content="width=device-width,initial-scale=1,shrink-to-fit=no"><meta name="theme-color" content="#000000"><meta name="keywords" content="react,react-component,array-viewer,base-16,component,interactive,interactive-json,json,json-component,json-display,json-tree,json-view,json-viewer,json-inspector,json-tree,react,react-component,react-json,theme,tree,tree-view,treeview,jaywcjlove"><meta name="description" content="A React component for displaying and editing javascript arrays and JSON objects."><link rel="shortcut icon" href="/favicon.ico"><title>react-json-view</title><script defer="defer" src="./static/js/refractor-prismjs-vendor.3665b250.53b94c40.js"></script><script defer="defer" src="./static/js/refractor-prismjs-vendor.a81a7d65.3c62cc2b.js"></script><script defer="defer" src="./static/js/refractor-prismjs-vendor.0abbb2f3.00343fb8.js"></script><script defer="defer" src="./static/js/react-vendor.5bec418d.js"></script><script defer="defer" src="./static/js/main.44e40c98.js"></script><link href="./static/css/main.7ea575dc.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>

‎lcov-report/index.html‎

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -23,30 +23,30 @@ <h1>All files</h1>
2323
<div class='clearfix'>
2424

2525
<div class='fl pad1y space-right2'>
26-
<span class="strong">92.37% </span>
26+
<span class="strong">92.41% </span>
2727
<span class="quiet">Statements</span>
28-
<span class='fraction'>787/852</span>
28+
<span class='fraction'>792/857</span>
2929
</div>
3030

3131

3232
<div class='fl pad1y space-right2'>
33-
<span class="strong">74.68% </span>
33+
<span class="strong">74.61% </span>
3434
<span class="quiet">Branches</span>
35-
<span class='fraction'>472/632</span>
35+
<span class='fraction'>479/642</span>
3636
</div>
3737

3838

3939
<div class='fl pad1y space-right2'>
40-
<span class="strong">83.68% </span>
40+
<span class="strong">83.21% </span>
4141
<span class="quiet">Functions</span>
42-
<span class='fraction'>118/141</span>
42+
<span class='fraction'>119/143</span>
4343
</div>
4444

4545

4646
<div class='fl pad1y space-right2'>
47-
<span class="strong">92.37% </span>
47+
<span class="strong">92.42% </span>
4848
<span class="quiet">Lines</span>
49-
<span class='fraction'>751/813</span>
49+
<span class='fraction'>756/818</span>
5050
</div>
5151

5252

@@ -80,17 +80,17 @@ <h1>All files</h1>
8080
</thead>
8181
<tbody><tr>
8282
<td class="file high" data-value="src"><a href="src/index.html">src</a></td>
83-
<td data-value="96.92" class="pic high">
84-
<div class="chart"><div class="cover-fill" style="width: 96%"></div><div class="cover-empty" style="width: 4%"></div></div>
83+
<td data-value="95.52" class="pic high">
84+
<div class="chart"><div class="cover-fill" style="width: 95%"></div><div class="cover-empty" style="width: 5%"></div></div>
8585
</td>
86-
<td data-value="96.92" class="pct high">96.92%</td>
87-
<td data-value="65" class="abs high">63/65</td>
88-
<td data-value="100" class="pct high">100%</td>
89-
<td data-value="10" class="abs high">10/10</td>
90-
<td data-value="72.72" class="pct medium">72.72%</td>
91-
<td data-value="11" class="abs medium">8/11</td>
92-
<td data-value="96.87" class="pct high">96.87%</td>
93-
<td data-value="64" class="abs high">62/64</td>
86+
<td data-value="95.52" class="pct high">95.52%</td>
87+
<td data-value="67" class="abs high">64/67</td>
88+
<td data-value="92.85" class="pct high">92.85%</td>
89+
<td data-value="14" class="abs high">13/14</td>
90+
<td data-value="69.23" class="pct medium">69.23%</td>
91+
<td data-value="13" class="abs medium">9/13</td>
92+
<td data-value="95.45" class="pct high">95.45%</td>
93+
<td data-value="66" class="abs high">63/66</td>
9494
</tr>
9595

9696
<tr>
@@ -110,17 +110,17 @@ <h1>All files</h1>
110110

111111
<tr>
112112
<td class="file high" data-value="src/comps"><a href="src/comps/index.html">src/comps</a></td>
113-
<td data-value="89.13" class="pic high">
113+
<td data-value="89.83" class="pic high">
114114
<div class="chart"><div class="cover-fill" style="width: 89%"></div><div class="cover-empty" style="width: 11%"></div></div>
115115
</td>
116-
<td data-value="89.13" class="pct high">89.13%</td>
117-
<td data-value="184" class="abs high">164/184</td>
118-
<td data-value="84" class="pct high">84%</td>
119-
<td data-value="175" class="abs high">147/175</td>
116+
<td data-value="89.83" class="pct high">89.83%</td>
117+
<td data-value="187" class="abs high">168/187</td>
118+
<td data-value="83.42" class="pct high">83.42%</td>
119+
<td data-value="181" class="abs high">151/181</td>
120120
<td data-value="82.6" class="pct high">82.6%</td>
121121
<td data-value="23" class="abs high">19/23</td>
122-
<td data-value="88.88" class="pct high">88.88%</td>
123-
<td data-value="180" class="abs high">160/180</td>
122+
<td data-value="89.61" class="pct high">89.61%</td>
123+
<td data-value="183" class="abs high">164/183</td>
124124
</tr>
125125

126126
<tr>
@@ -236,7 +236,7 @@ <h1>All files</h1>
236236
<div class='footer quiet pad2 space-top1 center small'>
237237
Code coverage generated by
238238
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
239-
at 2025-08-26T16:15:18.147Z
239+
at 2025-09-17T06:44:40.970Z
240240
</div>
241241
<script src="prettify.js"></script>
242242
<script>

‎lcov-report/src/Container.tsx.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ <h1><a href="../index.html">All files</a> / <a href="index.html">src</a> Contain
277277
<div class='footer quiet pad2 space-top1 center small'>
278278
Code coverage generated by
279279
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
280-
at 2025-08-26T16:15:18.147Z
280+
at 2025-09-17T06:44:40.970Z
281281
</div>
282282
<script src="../prettify.js"></script>
283283
<script>

‎lcov-report/src/arrow/TriangleArrow.tsx.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">src/arrow</a
136136
<div class='footer quiet pad2 space-top1 center small'>
137137
Code coverage generated by
138138
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
139-
at 2025-08-26T16:15:18.147Z
139+
at 2025-09-17T06:44:40.970Z
140140
</div>
141141
<script src="../../prettify.js"></script>
142142
<script>

‎lcov-report/src/arrow/TriangleSolidArrow.tsx.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">src/arrow</a
157157
<div class='footer quiet pad2 space-top1 center small'>
158158
Code coverage generated by
159159
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
160-
at 2025-08-26T16:15:18.147Z
160+
at 2025-09-17T06:44:40.970Z
161161
</div>
162162
<script src="../../prettify.js"></script>
163163
<script>

‎lcov-report/src/arrow/index.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ <h1><a href="../../index.html">All files</a> src/arrow</h1>
116116
<div class='footer quiet pad2 space-top1 center small'>
117117
Code coverage generated by
118118
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
119-
at 2025-08-26T16:15:18.147Z
119+
at 2025-09-17T06:44:40.970Z
120120
</div>
121121
<script src="../../prettify.js"></script>
122122
<script>

‎lcov-report/src/comps/Copied.tsx.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">src/comps</a
442442
<div class='footer quiet pad2 space-top1 center small'>
443443
Code coverage generated by
444444
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
445-
at 2025-08-26T16:15:18.147Z
445+
at 2025-09-17T06:44:40.970Z
446446
</div>
447447
<script src="../../prettify.js"></script>
448448
<script>

‎lcov-report/src/comps/KeyValues.tsx.html‎

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,16 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">src/comps</a
2323
<div class='clearfix'>
2424

2525
<div class='fl pad1y space-right2'>
26-
<span class="strong">98% </span>
26+
<span class="strong">98.03% </span>
2727
<span class="quiet">Statements</span>
28-
<span class='fraction'>49/50</span>
28+
<span class='fraction'>50/51</span>
2929
</div>
3030

3131

3232
<div class='fl pad1y space-right2'>
33-
<span class="strong">81.63% </span>
33+
<span class="strong">80.39% </span>
3434
<span class="quiet">Branches</span>
35-
<span class='fraction'>40/49</span>
35+
<span class='fraction'>41/51</span>
3636
</div>
3737

3838

@@ -44,9 +44,9 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">src/comps</a
4444

4545

4646
<div class='fl pad1y space-right2'>
47-
<span class="strong">98% </span>
47+
<span class="strong">98.03% </span>
4848
<span class="quiet">Lines</span>
49-
<span class='fraction'>49/50</span>
49+
<span class='fraction'>50/51</span>
5050
</div>
5151

5252

@@ -189,7 +189,9 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">src/comps</a
189189
<a name='L124'></a><a href='#L124'>124</a>
190190
<a name='L125'></a><a href='#L125'>125</a>
191191
<a name='L126'></a><a href='#L126'>126</a>
192-
<a name='L127'></a><a href='#L127'>127</a></td><td class="line-coverage quiet"><span class="cline-any cline-neutral">&nbsp;</span>
192+
<a name='L127'></a><a href='#L127'>127</a>
193+
<a name='L128'></a><a href='#L128'>128</a>
194+
<a name='L129'></a><a href='#L129'>129</a></td><td class="line-coverage quiet"><span class="cline-any cline-neutral">&nbsp;</span>
193195
<span class="cline-any cline-neutral">&nbsp;</span>
194196
<span class="cline-any cline-neutral">&nbsp;</span>
195197
<span class="cline-any cline-neutral">&nbsp;</span>
@@ -217,6 +219,8 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">src/comps</a
217219
<span class="cline-any cline-yes">119x</span>
218220
<span class="cline-any cline-neutral">&nbsp;</span>
219221
<span class="cline-any cline-yes">119x</span>
222+
<span class="cline-any cline-neutral">&nbsp;</span>
223+
<span class="cline-any cline-yes">119x</span>
220224
<span class="cline-any cline-yes">119x</span>
221225
<span class="cline-any cline-no">&nbsp;</span>
222226
<span class="cline-any cline-neutral">&nbsp;</span>
@@ -339,11 +343,13 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">src/comps</a
339343
const expands = useExpandsStore();
340344
const { objectSortKeys, indentWidth, collapsed, shouldExpandNodeInitially } = useStore();
341345
const defaultExpanded =
342-
typeof collapsed === 'boolean' ? <span class="branch-0 cbranch-no" title="branch not covered" >collapsed </span>: typeof collapsed === 'number' ? <span class="branch-0 cbranch-no" title="branch not covered" >level &gt; collapsed </span>: false;
343-
const isExpanded = expands[expandKey] ?? defaultExpanded;
346+
typeof collapsed === 'boolean' ? collapsed : <span class="branch-1 cbranch-no" title="branch not covered" >typeof collapsed === 'number' ? level &gt; collapsed : false;</span>
347+
const isExpanded = expands[expandKey] ?? (shouldExpandNodeInitially ? false : <span class="branch-1 cbranch-no" title="branch not covered" >defaultExpanded)</span>;
344348
const shouldExpand =
345-
shouldExpandNodeInitially &amp;&amp; <span class="branch-1 cbranch-no" title="branch not covered" >shouldExpandNodeInitially(isExpanded, { value, keys, level, keyName, parentValue });</span>
346-
<span class="missing-if-branch" title="if path not taken" >I</span>if (expands[expandKey] === undefined &amp;&amp; !!shouldExpand) {
349+
shouldExpandNodeInitially &amp;&amp; shouldExpandNodeInitially(!isExpanded, { value, keys, level, keyName, parentValue });
350+
&nbsp;
351+
console.log('KeyValues', expands[expandKey], defaultExpanded, !shouldExpand, shouldExpand, isExpanded);
352+
<span class="missing-if-branch" title="if path not taken" >I</span>if (expands[expandKey] === undefined &amp;&amp; !shouldExpand) {
347353
<span class="cstat-no" title="statement not covered" > return null;</span>
348354
}
349355
if (isExpanded) {
@@ -448,7 +454,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">src/comps</a
448454
<div class='footer quiet pad2 space-top1 center small'>
449455
Code coverage generated by
450456
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
451-
at 2025-08-26T16:15:18.147Z
457+
at 2025-09-17T06:44:40.970Z
452458
</div>
453459
<script src="../../prettify.js"></script>
454460
<script>

0 commit comments

Comments
 (0)