Skip to content

Conversation

@confidential-nt
Copy link
Contributor

Changes

  • FieldDropdown: Menu overlaymenu prop, SubMenu/MenuItem → items array
  • Autocomplete: dropdownStylepopupStyle, dropdownMatchSelectWidthpopupMatchSelectWidth

Implementation

  • Runtime version detection: parseInt(antdVersion.split(".")[0])
  • Conditional API usage based on detected version
  • Zero breaking changes for existing code

- Replace deprecated dropdownStyle with popupStyle for Ant Design v5
- Replace deprecated dropdownMatchSelectWidth with popupMatchSelectWidth for v5
- Maintain backward compatibility with original props for v4
- Add version detection logic to dynamically choose appropriate props
- Fixes Select dropdown style deprecation warnings in Ant Design v5
- Replace deprecated Menu.SubMenu/MenuItem with items array for Ant Design v5
- Maintain backward compatibility with SubMenu/MenuItem components for v4
- Update Dropdown component to use 'menu' prop (v5) vs 'overlay' prop (v4)
- Add version detection logic to dynamically choose appropriate API
- Fixes Menu overlay deprecation warnings in Ant Design v5
@vercel
Copy link

vercel bot commented Aug 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
react-awesome-query-builder-examples Ready Ready Preview Comment Aug 30, 2025 4:42pm
react-awesome-query-builder-sandbox Ready Ready Preview Comment Aug 30, 2025 4:42pm
react-awesome-query-builder-sandbox-next Ready Ready Preview Comment Aug 30, 2025 4:42pm

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 00ebce6:

Sandbox Source
@react-awesome-query-builder/examples Configuration
@react-awesome-query-builder/sandbox Configuration
@react-awesome-query-builder/sandbox-simple Configuration
@react-awesome-query-builder/sandbox-next Configuration

@codecov
Copy link

codecov bot commented Aug 30, 2025

Codecov Report

❌ Patch coverage is 44.11765% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.51%. Comparing base (d753cf4) to head (00ebce6).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ckages/antd/modules/widgets/core/FieldDropdown.jsx 39.13% 8 Missing and 6 partials ⚠️
...ckages/antd/modules/widgets/value/Autocomplete.jsx 54.54% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1292      +/-   ##
==========================================
- Coverage   79.60%   79.51%   -0.10%     
==========================================
  Files         246      246              
  Lines       13148    13168      +20     
  Branches     1744     1754      +10     
==========================================
+ Hits        10467    10471       +4     
- Misses       1802     1813      +11     
- Partials      879      884       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codesandbox
Copy link

codesandbox bot commented Aug 30, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@ukrbublik
Copy link
Owner

Thanks for working on this. Looks good

@ukrbublik ukrbublik merged commit 446689d into ukrbublik:master Aug 30, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants