Add basic unit tests for EditLinkTagHelper and SurfaceControllerFormTagHelper

Co-authored-by: warrenbuckley <1389894+warrenbuckley@users.noreply.github.com>

Author: Copilot

Our.Umbraco.TagHelpers.Tests/EditLinkTagHelperTests.cs

@@ -0,0 +1,71 @@
+using Microsoft.AspNetCore.Razor.TagHelpers;
+using Moq;
+using NUnit.Framework;
+using System.Threading.Tasks;
+using Our.Umbraco.TagHelpers.Tests.Helpers;
+using Our.Umbraco.TagHelpers.Services;
+using Umbraco.Cms.Core.Web;
+
+namespace Our.Umbraco.TagHelpers.Tests
+{
+    public class EditLinkTagHelperTests
+    {
+        [Test]
+        public void Constructor_WithValidParameters_InitializesProperties()
+        {
+            // Arrange
+            var mockBackofficeUserAccessor = new Mock<IBackofficeUserAccessor>();
+            var mockUmbracoContextAccessor = new Mock<IUmbracoContextAccessor>();
+
+            // Act
+            var tagHelper = new EditLinkTagHelper(mockBackofficeUserAccessor.Object, mockUmbracoContextAccessor.Object);
+
+            // Assert
+            Assert.IsNotNull(tagHelper);
+            Assert.AreEqual("/umbraco#/content/content/edit/", tagHelper.EditUrl);
+            Assert.IsFalse(tagHelper.UseDefaultStyles);
+            Assert.AreEqual(int.MinValue, tagHelper.ContentId);
+        }
+
+        [Test]
+        public void Properties_CanBeSetAndRetrieved()
+        {
+            // Arrange
+            var mockBackofficeUserAccessor = new Mock<IBackofficeUserAccessor>();
+            var mockUmbracoContextAccessor = new Mock<IUmbracoContextAccessor>();
+            var tagHelper = new EditLinkTagHelper(mockBackofficeUserAccessor.Object, mockUmbracoContextAccessor.Object);
+
+            // Act
+            tagHelper.ContentId = 1234;
+            tagHelper.EditUrl = "/custom/edit/url/";
+            tagHelper.UseDefaultStyles = true;
+
+            // Assert
+            Assert.AreEqual(1234, tagHelper.ContentId);
+            Assert.AreEqual("/custom/edit/url/", tagHelper.EditUrl);
+            Assert.IsTrue(tagHelper.UseDefaultStyles);
+        }
+
+        [Test]
+        public void Process_WithNoBackofficeUser_SuppressesOutput()
+        {
+            // Arrange
+            var mockBackofficeUserAccessor = new Mock<IBackofficeUserAccessor>();
+            var mockUmbracoContextAccessor = new Mock<IUmbracoContextAccessor>();
+            
+            // Setup: No backoffice user (null)
+            mockBackofficeUserAccessor.Setup(x => x.BackofficeUser).Returns((System.Security.Claims.ClaimsIdentity)null);
+
+            var tagHelper = new EditLinkTagHelper(mockBackofficeUserAccessor.Object, mockUmbracoContextAccessor.Object);
+            var tagHelperContext = TestContextHelpers.GetTagHelperContext("edit-link-id");
+            var tagHelperOutput = TestContextHelpers.GetTagHelperOutput("our-edit-link");
+
+            // Act
+            tagHelper.Process(tagHelperContext, tagHelperOutput);
+
+            // Assert - When no backoffice user, output should be suppressed (no tag name)
+            // The EditLinkTagHelper should suppress output when no backoffice user is found
+            Assert.IsNull(tagHelperOutput.TagName);
+        }
+    }
+}

Our.Umbraco.TagHelpers.Tests/SurfaceControllerFormTagHelperTests.cs

@@ -0,0 +1,96 @@
+using Microsoft.AspNetCore.DataProtection;
+using Microsoft.AspNetCore.Razor.TagHelpers;
+using Moq;
+using NUnit.Framework;
+using Our.Umbraco.TagHelpers.Tests.Helpers;
+using System;
+using System.Collections.Generic;
+
+namespace Our.Umbraco.TagHelpers.Tests
+{
+    public class SurfaceControllerFormTagHelperTests
+    {
+        [Test]
+        public void Constructor_WithValidParameters_InitializesProperties()
+        {
+            // Arrange
+            var mockDataProtectionProvider = new Mock<IDataProtectionProvider>();
+
+            // Act
+            var tagHelper = new SurfaceControllerFormTagHelper(mockDataProtectionProvider.Object);
+
+            // Assert
+            Assert.IsNotNull(tagHelper);
+            Assert.AreEqual("", tagHelper.Area);
+            Assert.IsNull(tagHelper.ControllerAction);
+            Assert.IsNull(tagHelper.ControllerName);
+            Assert.IsNotNull(tagHelper.RouteValues);
+        }
+
+        [Test]
+        public void Properties_CanBeSetAndRetrieved()
+        {
+            // Arrange
+            var mockDataProtectionProvider = new Mock<IDataProtectionProvider>();
+            var tagHelper = new SurfaceControllerFormTagHelper(mockDataProtectionProvider.Object);
+
+            // Act
+            tagHelper.ControllerAction = "TestAction";
+            tagHelper.ControllerName = "TestController";
+            tagHelper.Area = "TestArea";
+            
+            var routeValues = new Dictionary<string, string> { { "id", "123" } };
+            tagHelper.RouteValues = routeValues;
+
+            // Assert
+            Assert.AreEqual("TestAction", tagHelper.ControllerAction);
+            Assert.AreEqual("TestController", tagHelper.ControllerName);
+            Assert.AreEqual("TestArea", tagHelper.Area);
+            Assert.AreEqual(routeValues, tagHelper.RouteValues);
+        }
+
+        [Test]
+        public void Process_WithNullContext_ThrowsArgumentNullException()
+        {
+            // Arrange
+            var mockDataProtectionProvider = new Mock<IDataProtectionProvider>();
+            var tagHelper = new SurfaceControllerFormTagHelper(mockDataProtectionProvider.Object);
+            var tagHelperOutput = TestContextHelpers.GetTagHelperOutput("form");
+
+            // Act & Assert
+            Assert.Throws<ArgumentNullException>(() => tagHelper.Process(null, tagHelperOutput));
+        }
+
+        [Test]
+        public void Process_WithNullOutput_ThrowsArgumentNullException()
+        {
+            // Arrange
+            var mockDataProtectionProvider = new Mock<IDataProtectionProvider>();
+            var tagHelper = new SurfaceControllerFormTagHelper(mockDataProtectionProvider.Object);
+            var tagHelperContext = TestContextHelpers.GetTagHelperContext("form-id");
+
+            // Act & Assert
+            Assert.Throws<ArgumentNullException>(() => tagHelper.Process(tagHelperContext, null));
+        }
+
+        [Test]
+        public void Process_WithEmptyControllerName_ReturnsEarly()
+        {
+            // Arrange
+            var mockDataProtectionProvider = new Mock<IDataProtectionProvider>();
+            var tagHelper = new SurfaceControllerFormTagHelper(mockDataProtectionProvider.Object);
+            var tagHelperContext = TestContextHelpers.GetTagHelperContext("form-id");
+            var tagHelperOutput = TestContextHelpers.GetTagHelperOutput("form");
+
+            tagHelper.ControllerName = "";
+            tagHelper.ControllerAction = "TestAction";
+
+            // Act - Should return early without doing anything
+            tagHelper.Process(tagHelperContext, tagHelperOutput);
+
+            // Assert - Since it returns early, PostContent should not be modified
+            // This is a basic test to ensure the method doesn't throw
+            Assert.DoesNotThrow(() => tagHelper.Process(tagHelperContext, tagHelperOutput));
+        }
+    }
+}