Skip to content

Remove trash success notifications #19534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2025

Conversation

madsrasmussen
Copy link
Contributor

This PR removes the success notifications when a document or media is trashed. We already updates the tree/collection when it happens.

@Copilot Copilot AI review requested due to automatic review settings June 12, 2025 08:24
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes success notifications for trash and empty actions on documents or media to rely on the tree/collection update mechanism instead.

  • Removed trash success notifications in requestTrash
  • Removed notifications on recycle bin emptying in requestEmpty
  • Retained restore notifications with a TODO note for future refinement
Comments suppressed due to low confidence (2)

src/Umbraco.Web.UI.Client/src/packages/core/recycle-bin/recycle-bin-repository-base.ts:63

  • Consider updating the TODO comment with more detailed guidance or context regarding when and how the restore notification should eventually be removed or modified. This can help maintain clear long-term expectations for the notification behavior.
// TODO: keep this notification until we refresh the tree/structure correctly after the action

src/Umbraco.Web.UI.Client/src/packages/core/recycle-bin/recycle-bin-repository-base.ts:60

  • The removal of notifications in requestTrash and requestEmpty contrasts with retaining a notification in requestRestore. Confirm that keeping the restore notification is intentional and that its behavior aligns with the overall user experience design.
const { error } = await this.#recycleBinSource.restore(args);

@iOvergaard iOvergaard merged commit 5cafa59 into main Jun 27, 2025
27 checks passed
@iOvergaard iOvergaard deleted the v16/bugfix/remove-trash-notifications branch June 27, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants