Show success/failed state for workspace buttons with additional options #19535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables showing the success or failure state on workspace action buttons even when additional options are present, and automatically resets the state after a delay.
- Always sets
_buttonStateto'success'or'failed'regardless of_additionalOptions - Introduces
#initButtonStateReset()to clear the state after 2 seconds - Removes the previous guard around setting the button state
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-action/default/workspace-action-default-kind.element.ts:144
- Add a unit or integration test to verify that
_buttonStateresets to undefined after the 2-second delay, covering this new behavior.
setTimeout(() => {
.../core/workspace/components/workspace-action/default/workspace-action-default-kind.element.ts
Outdated
Show resolved
Hide resolved
.../core/workspace/components/workspace-action/default/workspace-action-default-kind.element.ts
Outdated
Show resolved
Hide resolved
.../core/workspace/components/workspace-action/default/workspace-action-default-kind.element.ts
Outdated
Show resolved
Hide resolved
…ave-additional-options
iOvergaard
approved these changes
Jun 27, 2025
iOvergaard
deleted the
v16/bugfix/show-save-checkmark-when-button-have-additional-options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the success/failure state for workspace buttons with additional options. We still do not display the waiting state, as it does not make sense to show when a dialog is open.