Skip to content

Improves the layout on the create blueprint dialog #19556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AndyButland
Copy link
Contributor

Description

Noticed in testing functionality related to blueprints that the dialog isn't really styled very well. This updates it to match other similar screens.

Before:
image

After:
image

@Copilot Copilot AI review requested due to automatic review settings June 13, 2025 13:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors the Create Blueprint modal to use the standardized body/box layouts and property layout for the blueprint name field, aligning its styling with other dialogs.

  • Inlines rendering of the blueprint name field into the main render() method.
  • Wraps the name input in umb-property-layout and removes the old #renderBlueprintName helper.
  • Updates the modal headline and box structure to match other similar screens.
Comments suppressed due to low confidence (2)

src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/create-blueprint/modal/create-blueprint-modal.element.ts:44

  • [nitpick] The id "tree-box" doesn't reflect this component's purpose. Consider renaming it to something like "blueprint-box" or "create-blueprint-box" for clarity.
<uui-box id="tree-box" headline="Create a new Content Template from ${this._documentName}">

src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/create-blueprint/modal/create-blueprint-modal.element.ts:50

  • The uui-input label attribute is redundant when wrapped by umb-property-layout, which already provides the field label. You can remove the label prop to avoid duplicate labeling.
label="name"

Copy link
Contributor

@madsrasmussen madsrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 👍

FYI: I have localized the texts in the modal.

@madsrasmussen madsrasmussen enabled auto-merge (squash) June 24, 2025 07:31
@madsrasmussen madsrasmussen merged commit 6237ddc into main Jun 24, 2025
27 checks passed
@madsrasmussen madsrasmussen deleted the v16/improvement/styling-on-create-blueprint-dialog branch June 24, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants