Edited field in a workflow does not trigger condition

[SelwynEdelbroek]

Which Umbraco Forms version are you using? (Please write the exact version, example: 13.4.0)

13.5.0

Which Umbraco version are you using? (Please write the exact version, example: 13.5.2)

13.9.3

Issue summary

When a custom Umbraco Workflow changes a value from a field, the following chained workflows with condition that check this field always fails.

Specifics

No response

Steps to reproduce

1. Create custom workflow that updates a hidden value
2. Create form with hidden value
3. Add custom workflow to form
4. Add any workflow that triggers with conditions on the hidden value
5. Submit form

Expected result / actual result

Expected result:
The expected result would be that the state of the forms field should be checked across all the workflows.

Actual result:
When a value has been added or updated the following workflow conditions are skipped. After a workflow execution the state is never updated.

---

This item has been added to our backlog AB#61143

[mattbrailsford]

@SelwynEdelbroek when you say "Create custom workflow that updates a hidden value" is that using one of the built in workflow steps? or something custom? If the former, can you share the exact workflow config you have? or if the later, can you share a code snippet for your custom workflow?

[SelwynEdelbroek]

Hi @mattbrailsford,

Here is the workflow that should update the hidden field. If we add this workflow, a mail workflow that has a condition for the hidden field that has a score of 20 or higher the condition always fails.

using Microsoft.Extensions.Logging;
using Newtonsoft.Json;
using System;
using System.Collections.Generic;
using System.Threading.Tasks;
using Umbraco.Forms.Core;
using Umbraco.Forms.Core.Attributes;
using Umbraco.Forms.Core.Enums;

public class FieldScoringWorkflow : WorkflowType
{
    private readonly ILogger<FieldScoringWorkflow> _logger;

    // [Setting("Velden", Description = "Koppel velden van Umbraco Forms", DisplayOrder = 1, View = Perplex.UmbracoForms.FieldMap.Constants.FIELD_MAP_VIEW_PATH)]
    // public string FieldMap { get; set; } = string.Empty;

    public FieldScoringWorkflow(ILogger<FieldScoringWorkflow> logger)
    {
        _logger = logger;
        Id = new Guid("977a3153-40ec-4ab5-9d72-f3c4f94e4933");
        Name = "FieldScoringWorkflow";
        Description = "Updates a property named 'totalScore' with a score based on answers from questions.";
        Icon = "icon-code";
        Group = "Services";
    }

    public async override Task<WorkflowExecutionStatus> ExecuteAsync(WorkflowExecutionContext context)
    {
        // Fetch hidden field by alias and update its value with the total score
        var totalScoreRecordField = context.Record.GetRecordFieldByAlias("totalScore");
        if (totalScoreRecordField is null)
        {
            _logger.LogError("Hidden field 'totalScore' not found");
            throw new ArgumentException("Hidden field 'totalScore' not found");
        }

        int totalScore = 0;
        // Logic for scoring, Total score is calculated based on the answers provided in the form
        // Scoring can be also set to 50 for testing

        if (context.AdditionalData != null && context.AdditionalData.TryGetValue("score", out var scoreObj))
        {
            if (int.TryParse(scoreObj?.ToString(), out var score))
            {
                totalScore += score;
            }
        }


        totalScoreRecordField.Values = [totalScore.ToString()];
        return WorkflowExecutionStatus.Completed;
    }

    public override List<Exception> ValidateSettings()
    {
        var exceptions = new List<Exception>();

        // DO NOTHING

        return exceptions;
    }
}

[mattbrailsford]

Ok great, let me test this out tomorrow and I'll see what I can find

[mattbrailsford]

Ok, I've managed to replicate this and now see what the issue is.

It looks like when we run the configured workflows at the start of the run we capture all the form field values to be used by conditions, then whenever we loop the workflows it's this initial collection that is checked. As you are changing the value within the workflow, the collection of fields that was snapshotted at the start doesn't contain your updated value. Additionally, it looks like the condition functionality only runs on form field values, not the record entity which you are updating.

I'll add this to our sprint backlog to see what the best course of action should be. In the meantime, you might need to use a custom workflow for your second task and have that check the output from the first task.

[SelwynEdelbroek]

Hi @mattbrailsford, Thanks for looking into to this. We will look for the different approach to solve this for now! 😄