Skip to content

test_arm64_mem_hook_read_write fails on riscv64 and s390x #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
strophy opened this issue Mar 5, 2025 · 12 comments
Open

test_arm64_mem_hook_read_write fails on riscv64 and s390x #2124

strophy opened this issue Mar 5, 2025 · 12 comments

Comments

@strophy
Copy link

strophy commented Mar 5, 2025

I am experiencing the following test_arm and test_arm64 errors after successful build from current master on riscv64 and s390x arch under Alpine Linux 3.21:

Test test_arm64_mem_hook_read_write...          [ FAILED ]
  test_arm64.c:649: Check counter[0] == 4 && counter[1] == 4... failed

and

Test test_arm_mem_hook_read_write...            [ FAILED ]
  test_arm.c:864: Check counter[0] == 2 && counter[1] == 2... failed

Additionally s390x throws errors for test_mem, test_riscv and test_x86, I'll open a separate issue for that if necessary after this one.

Build logs are here: https://gitlab.alpinelinux.org/strophy/aports/-/pipelines/304520
I'm happy to push builds from specific commits through the Alpine CI system when you tag me, or you can do this yourself with a free account.

@flyn-org
Copy link

flyn-org commented Mar 8, 2025

Building unicorn 2.1.3 on Fedora Rawhide has similar results. A log of the build is available at the URL below. The bottom of the log documents the failing tests.

https://download.copr.fedorainfracloud.org/results/mikep/scratch/fedora-rawhide-s390x/08742932-unicorn/builder-live.log.gz

@wtdcode
Copy link
Member

wtdcode commented Mar 12, 2025

Building unicorn 2.1.3 on Fedora Rawhide has similar results. A log of the build is available at the URL below. The bottom of the log documents the failing tests.

https://download.copr.fedorainfracloud.org/results/mikep/scratch/fedora-rawhide-s390x/08742932-unicorn/builder-live.log.gz

Thanks for updating here. Unfortunately, as I replied elsewhere, I can't do too much without access to a s390x environment. I will tey to emulate one via qemu later.

@sharkcz
Copy link

sharkcz commented Apr 10, 2025

hi @wtdcode , if access to a s390x system would help, then please let me know, I can arrange that.

@wtdcode
Copy link
Member

wtdcode commented Apr 10, 2025

hi @wtdcode , if access to a s390x system would help, then please let me know, I can arrange that.

Thanks for that. You might send the way to access the environment by emailing me: mio@lazym.io

@sharkcz
Copy link

sharkcz commented Apr 10, 2025

mail sent

@wtdcode
Copy link
Member

wtdcode commented Apr 13, 2025

During porting to s390x, I submitted another patch to QEMU:

https://lore.kernel.org/qemu-devel/20250413172242.3430944-1-ziqiaokong@gmail.com/T/#t

@wtdcode
Copy link
Member

wtdcode commented Apr 14, 2025

I'm done with initial port to s390x in acb638c but still we need some further testing for the incoming 2.2.0 with several big changes.

[mio@lfedora2 build]$ ctest
Test project /home/mio/unicorn/build
      Start  1: test_x86
 1/12 Test  #1: test_x86 .........................   Passed    1.15 sec
      Start  2: test_arm
 2/12 Test  #2: test_arm .........................   Passed    0.21 sec
      Start  3: test_arm64
 3/12 Test  #3: test_arm64 .......................   Passed    0.06 sec
      Start  4: test_m68k
 4/12 Test  #4: test_m68k ........................   Passed    0.01 sec
      Start  5: test_mips
 5/12 Test  #5: test_mips ........................   Passed    0.02 sec
      Start  6: test_sparc
 6/12 Test  #6: test_sparc .......................   Passed    0.00 sec
      Start  7: test_ppc
 7/12 Test  #7: test_ppc .........................   Passed    0.03 sec
      Start  8: test_riscv
 8/12 Test  #8: test_riscv .......................   Passed    0.06 sec
      Start  9: test_s390x
 9/12 Test  #9: test_s390x .......................   Passed    0.01 sec
      Start 10: test_tricore
10/12 Test #10: test_tricore .....................   Passed    0.00 sec
      Start 11: test_mem
11/12 Test #11: test_mem .........................   Passed    0.03 sec
      Start 12: test_ctl
12/12 Test #12: test_ctl .........................   Passed    0.05 sec

100% tests passed, 0 tests failed out of 12

Total Test time (real) =   1.65 sec
[mio@lfedora2 build]$

However, as this is no CI support, we are likely to break it some time in the future, I would appreciate it if anyone would like to offer a s390x CI environment =).

@Antelox
Copy link
Contributor

Antelox commented Apr 14, 2025

I think we can add one more matrix element in the workflow using the qemu action with that arch settings

@sharkcz
Copy link

sharkcz commented Apr 14, 2025

I'm done with initial port to s390x in acb638c but still we need some further testing for the incoming 2.2.0 with several big changes.

However, as this is no CI support, we are likely to break it some time in the future, I would appreciate it if anyone would like to offer a s390x CI environment =).

Isn't s390x available in the github actions? I have found some references that it should be ...

@wtdcode
Copy link
Member

wtdcode commented Apr 14, 2025

I'm done with initial port to s390x in acb638c but still we need some further testing for the incoming 2.2.0 with several big changes.
However, as this is no CI support, we are likely to break it some time in the future, I would appreciate it if anyone would like to offer a s390x CI environment =).

Isn't s390x available in the github actions? I have found some references that it should be ...

Github doesn't provide officially hosted runners and thus the only way is to spin up a qemu emulated s390x, which is painful slow. As previously tested, this could take ~30 minutes to complete building and testing.

@sharkcz
Copy link

sharkcz commented Apr 14, 2025

@wtdcode
Copy link
Member

wtdcode commented Apr 14, 2025

Ah, I see, then self-hosted runners can be used per https://community.ibm.com/community/user/ibmz-and-linuxone/blogs/mingmay-pang2/2024/02/05/github-actions-runner-for-ibm-z-and-linuxone

I submitted a request there. Let's see. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants