Merge pull request #4229 from masatake/sql--postgresql-trigger

SQL: extract trigger of Postgresql dialect

Author: masatake

Units/parser-sql.r/db-trig.sql.d/expected.tags

@@ -1,3 +1,4 @@
+evr_update_trigger_katello_rpms	input-0.sql	/^CREATE TRIGGER evr_update_trigger_katello_rpms$/;"	T	table:katello_rpms
 flag	input.sql	/^        flag number := 0;$/;"	l	trigger:restrict_login
 restrict_login	input.sql	/^create or replace trigger restrict_login$/;"	T	table:database
 startup_db	input.sql	/^CREATE OR REPLACE TRIGGER startup_db$/;"	T	table:database

Units/parser-sql.r/db-trig.sql.d/input-0.sql

@@ -0,0 +1,11 @@
+CREATE TRIGGER evr_update_trigger_katello_rpms
+  BEFORE UPDATE OF epoch, version, release
+  ON katello_rpms
+  FOR EACH ROW
+  WHEN (
+    OLD.epoch IS DISTINCT FROM NEW.epoch OR
+    OLD.version IS DISTINCT FROM NEW.version OR
+    OLD.release IS DISTINCT FROM NEW.release
+  )
+  EXECUTE PROCEDURE evr_trigger();
+  -- Taken from katello-4.11.0.12/db/triggers/evr_update_trigger_katello_rpms_v01.sql

parsers/sql.c

@@ -2526,6 +2526,10 @@ static void parseTrigger (tokenInfo *const token)
 	 *	   create trigger "owner"."tr4" begin end;
 	 *	   create trigger "tr5" not valid;
 	 *	   create trigger "tr6" begin end;
+	 *
+	 * (PostgreSQL)
+	 *	   create trigger trigger ... on table ... execute procedure fn();
+	 *
 	 */
 
 	readIdentifier (name);
@@ -2556,6 +2560,7 @@ static void parseTrigger (tokenInfo *const token)
 
 		while (! isKeyword (token, KEYWORD_begin) &&
 			   ! isKeyword (token, KEYWORD_call) &&
+			   ! isKeyword (token, KEYWORD_procedure) &&
 			   ! isCmdTerm (token) &&
 			   ! isType (token, TOKEN_EOF))
 		{
@@ -2571,7 +2576,8 @@ static void parseTrigger (tokenInfo *const token)
 		}
 
 		if (isKeyword (token, KEYWORD_begin) ||
-			isKeyword (token, KEYWORD_call))
+			isKeyword (token, KEYWORD_call)  ||
+			isKeyword (token, KEYWORD_procedure))
 		{
 			addToScope(name, table->string, SQLTAG_TABLE);
 			makeSqlTag (name, SQLTAG_TRIGGER);