Merge pull request #4242 from masatake/fix-wrong-parser-version

Fix wrong parser versions

Author: masatake

Tmain/broken-version.d/exit-expected.txt

@@ -0,0 +1 @@
+1

Tmain/broken-version.d/run.sh

@@ -0,0 +1,12 @@
+#!/bin/sh
+
+# Copyright: 2025 Masatake YAMATO
+# License: GPL-2
+
+CTAGS=$1
+
+. ../utils.sh
+
+is_feature_available "$CTAGS" debug
+${CTAGS} --quiet --options=NONE --langdef=BROKEN'{version=0.1}' --_force-quit=1
+exit $?

Tmain/broken-version.d/stderr-expected.txt

@@ -0,0 +1 @@
+ctags: Warning: versionCurrent (0) must be either equal to or greater than versionAge (1): BROKEN

Tmain/json-output-format.d/stdout-expected.txt

@@ -86,7 +86,7 @@
 {"_type": "ptag", "name": "TAG_PARSER_VERSION", "parserName": "C", "path": "1.1", "pattern": "current.age"}
 {"_type": "ptag", "name": "TAG_PARSER_VERSION", "parserName": "Go", "path": "0.0", "pattern": "current.age"}
 {"_type": "ptag", "name": "TAG_PARSER_VERSION", "parserName": "Man", "path": "0.0", "pattern": "current.age"}
-{"_type": "ptag", "name": "TAG_PARSER_VERSION", "parserName": "Python", "path": "0.1", "pattern": "current.age"}
+{"_type": "ptag", "name": "TAG_PARSER_VERSION", "parserName": "Python", "path": "1.1", "pattern": "current.age"}
 {"_type": "ptag", "name": "TAG_PATTERN_LENGTH_LIMIT", "path": "96", "pattern": "0 for no limit"}
 {"_type": "ptag", "name": "TAG_PROGRAM_AUTHOR", "path": "Universal Ctags Team", "pattern": ""}
 {"_type": "ptag", "name": "TAG_PROGRAM_NAME", "path": "Universal Ctags", "pattern": "Derived from Exuberant Ctags"}

main/parse.c

@@ -1983,6 +1983,12 @@ static void initializeParsingCommon (parserDefinition *def, bool is_builtin,
 	else
 		verbose ("Add optlib parser: %s\n", def->name);
 
+	if (! (def->versionCurrent >= def->versionAge))
+		error (WARNING, "versionCurrent (%u) must be either equal to or greater than versionAge (%u): %s",
+			   def->versionCurrent, def->versionAge, def->name);
+	if (is_builtin)
+		Assert (def->versionCurrent >= def->versionAge);
+
 	def->id = LanguageCount++;
 	parser = LanguageTable + def->id;
 	parser->def = def;

parsers/clojure.c

@@ -174,7 +174,7 @@ extern parserDefinition *ClojureParser (void)
 	def->aliases = aliases;
 	def->parser = findClojureTags;
 	def->useCork = CORK_QUEUE;
-	def->versionCurrent = 0;
+	def->versionCurrent = 1;
 	def->versionAge = 1;
 	return def;
 }

parsers/lisp.c

@@ -528,7 +528,7 @@ extern parserDefinition* LispParser (void)
 	def->parser     = findLispTags;
 	def->selectLanguage = selectors;
 	def->useCork = CORK_QUEUE;
-	def->versionCurrent = 0;
+	def->versionCurrent = 1;
 	def->versionAge = 1;
 	return def;
 }
@@ -551,7 +551,7 @@ extern parserDefinition* EmacsLispParser (void)
 	def->aliases = aliases;
 	def->parser     = findEmacsLispTags;
 	def->useCork = CORK_QUEUE;
-	def->versionCurrent = 0;
+	def->versionCurrent = 1;
 	def->versionAge = 1;
 	return def;
 }

parsers/python.c

@@ -1874,7 +1874,7 @@ extern parserDefinition* PythonParser (void)
 	def->fieldCount = ARRAY_SIZE (PythonFields);
 	def->useCork = CORK_QUEUE;
 	def->requestAutomaticFQTag = true;
-	def->versionCurrent = 0;
+	def->versionCurrent = 1;
 	def->versionAge = 1;
 	return def;
 }

parsers/scheme.c

@@ -122,7 +122,7 @@ extern parserDefinition* SchemeParser (void)
 	def->aliases    = aliases;
 	def->parser     = findSchemeTags;
 	def->useCork = CORK_QUEUE;
-	def->versionCurrent = 0;
+	def->versionCurrent = 1;
 	def->versionAge = 1;
 	return def;
 }