optlib: allow users to set fields and check extras defined in a foreign language #3960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3960 +/- ##
==========================================
+ Coverage 85.84% 85.85% +0.01%
==========================================
Files 244 244
Lines 62904 62986 +82
==========================================
+ Hits 53997 54079 +82
Misses 8907 8907 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
masatake
force-pushed
the
main--foreign-fields
branch
2 times, most recently
from
e14c4e6 to
cbdc8c8
Compare
|
The ways to support boolean fields are not consistent in various aspects. |
masatake
force-pushed
the
main--foreign-fields
branch
2 times, most recently
from
d9408cb to
ae46592
Compare
masatake
force-pushed
the
main--foreign-fields
branch
from
ae46592 to
eba8b2e
Compare
|
I added test cases. The top half of this pull request can be merged. I will make a pull request. |
masatake
force-pushed
the
main--foreign-fields
branch
from
eba8b2e to
c50fcca
Compare
masatake
force-pushed
the
main--foreign-fields
branch
2 times, most recently
from
8f2f83d to
8ea0aa6
Compare
|
This pull request was for a Texinfo parser. |
masatake
force-pushed
the
main--foreign-fields
branch
from
8ea0aa6 to
7805e78
Compare
masatake
force-pushed
the
main--foreign-fields
branch
2 times, most recently
from
4a62955 to
b8b157f
Compare
masatake
force-pushed
the
main--foreign-fields
branch
3 times, most recently
from
a47f1bb to
0d32e66
Compare
masatake
force-pushed
the
main--foreign-fields
branch
from
0d32e66 to
84bb07f
Compare
masatake
force-pushed
the
main--foreign-fields
branch
from
84bb07f to
b478bd4
Compare
masatake
force-pushed
the
main--foreign-fields
branch
2 times, most recently
from
ed95293 to
c2124f1
Compare
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
=+ does the same as = but doesn't print newline at the end of output. ==+ does the same as == but doesn't print newline at the end of output. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
The name of operators has following form: setter => <LANG>.<FIELD>: getter => :<LANG>.<FIELD> The operators for a field are automatically defined only if the field has a setter and a getter in C language level; the operators require that the fieldDefinition for the field has getValueObject method setValueObject method. Currently, no parser has such methods. So, we cannot test the new code added with this commit yet. In later commits, I will implement the methods for fields defined with --_fielddef option. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
main--foreign-fields
branch
3 times, most recently
from
783dc37 to
d35fb78
Compare
…s defined in an optlib parser Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
…efined in optlib Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
main--foreign-fields
branch
from
d35fb78 to
d87078d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, this pull request allows you to fill out a field for a foreign tag from optscript.