CPreProcessor: (bugfix) don't return negative value other than EOF from unget-buffer #4234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om unget-buffer Fix universal-ctags#4222 When putting a char getting from the unget-buffer to a vstring, returning a nagative value caused a crash. This change focuses on values returned from ungetBufferGetcFromUngetBuffer, a function for getting from the unget-buffer. I will revise the functions putting values to the unget-buffer in the later commits. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
The original code focuses on the phase of getting a value from the unget-buffer. As a fundamental fix, this change focuses on the phase of putting values to the unget-buffer. Fixing the original bug at the getting phase was just a workaround. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4234 +/- ##
==========================================
+ Coverage 85.84% 85.85% +0.01%
==========================================
Files 242 242
Lines 62608 62610 +2
==========================================
+ Hits 53744 53752 +8
+ Misses 8864 8858 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We never store STRING_SYMBOL, CHAR_SYMBOL, and EOF to the unget-buffer. The original code was designed before I introduced charOrStringContents. In the design, STRING_SYMBOL and CHAR_SYMBOL could be stored to the unget-buffer. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
cpreprocessor--cast-unget-data
branch
from
4cba546 to
5152f6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4222.
This pull request consists of several commits.
They are redundant but descriptive.
The bug reported in #4222 was introduced in #4198.