Skip to content

CPreProcessor: (bugfix) don't return negative value other than EOF from unget-buffer #4234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Units/parser-cpreprocessor.r/unget-mbyte-string.d/README
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This is a crash test.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
i"犬"
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
a(i'犬'
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
i'犬'
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
a(i"犬猫鼠羊兎鶏牛熊"
/* Push back a logger string */
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
a(i"犬"
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This is a crash test.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
i"犬"
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
a(i'犬'
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
i'犬'
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
a(i"犬"
30 changes: 17 additions & 13 deletions parsers/cpreprocessor.c
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@
/* Defines the current state of the pre-processor.
*/
typedef struct sUngetBuffer {
int *buffer; /* memory buffer for unget characters */
unsigned char *buffer; /* memory buffer for unget characters */
int size; /* the current unget buffer size */
int *pointer; /* the current unget char: points in the
unsigned char *pointer; /* the current unget char: points in the
middle of the buffer */
int dataSize; /* the number of valid unget characters
in the buffer */
Expand Down Expand Up @@ -551,17 +551,20 @@
return;
}

Assert((unsigned int)c <= 0xff);
unsigned char u = (unsigned char)c;

if(!ungetBuffer->pointer)
{
// no unget data
if(!ungetBuffer->buffer)
{
ungetBuffer->buffer = (int *)eMalloc(8 * sizeof(int));
ungetBuffer->buffer = eMalloc(8 * sizeof(*(ungetBuffer->buffer)));
ungetBuffer->size = 8;
}
Assert(ungetBuffer->size > 0);
ungetBuffer->pointer = ungetBuffer->buffer + ungetBuffer->size - 1;
*(ungetBuffer->pointer) = c;
*(ungetBuffer->pointer) = u;
ungetBuffer->dataSize = 1;
return;
}
Expand All @@ -575,16 +578,16 @@
if(ungetBuffer->pointer == ungetBuffer->buffer)
{
ungetBuffer->size += 8;
int * tmp = (int *)eMalloc(ungetBuffer->size * sizeof(int));
memcpy(tmp+8,ungetBuffer->pointer,ungetBuffer->dataSize * sizeof(int));
unsigned char * tmp = eMalloc(ungetBuffer->size * sizeof(*(ungetBuffer->buffer)));
memcpy(tmp+8,ungetBuffer->pointer,ungetBuffer->dataSize * sizeof(*(ungetBuffer->buffer)));
eFree(ungetBuffer->buffer);
ungetBuffer->buffer = tmp;
ungetBuffer->pointer = tmp + 7;
} else {
ungetBuffer->pointer--;
}

*(ungetBuffer->pointer) = c;
*(ungetBuffer->pointer) = u;
ungetBuffer->dataSize++;
}

Expand All @@ -606,11 +609,12 @@
if(!ungetBuffer->buffer)
{
ungetBuffer->size = 8 + len;
ungetBuffer->buffer = (int *)eMalloc(ungetBuffer->size * sizeof(int));
ungetBuffer->buffer = eMalloc(ungetBuffer->size * sizeof(*(ungetBuffer->buffer)));
} else if(ungetBuffer->size < len)
{
ungetBuffer->size = 8 + len;
ungetBuffer->buffer = (int *)eRealloc(ungetBuffer->buffer,ungetBuffer->size * sizeof(int));
ungetBuffer->buffer = eRealloc(ungetBuffer->buffer,

Check warning on line 616 in parsers/cpreprocessor.c

View check run for this annotation

Codecov / codecov/patch

parsers/cpreprocessor.c#L616

Added line #L616 was not covered by tests
ungetBuffer->size * sizeof(*(ungetBuffer->buffer)));
}
ungetBuffer->pointer = ungetBuffer->buffer + ungetBuffer->size - len;
} else {
Expand All @@ -623,8 +627,8 @@
if(ungetBuffer->size < (ungetBuffer->dataSize + len))
{
ungetBuffer->size = 8 + len + ungetBuffer->dataSize;
int * tmp = (int *)eMalloc(ungetBuffer->size * sizeof(int));
memcpy(tmp + 8 + len,ungetBuffer->pointer,ungetBuffer->dataSize * sizeof(int));
unsigned char * tmp = eMalloc(ungetBuffer->size * sizeof(*(ungetBuffer->buffer)));
memcpy(tmp + 8 + len,ungetBuffer->pointer,ungetBuffer->dataSize * sizeof(*(ungetBuffer->buffer)));
eFree(ungetBuffer->buffer);
ungetBuffer->buffer = tmp;
ungetBuffer->pointer = tmp + 8;
Expand All @@ -634,12 +638,12 @@
}
}

int * p = ungetBuffer->pointer;
unsigned char* p = ungetBuffer->pointer;
const char * s = string;
const char * e = string + len;

while(s < e)
*p++ = *s++;
*p++ = (unsigned char)(*s++);

ungetBuffer->dataSize += len;
}
Expand Down
Loading