[DSP] Can somone explain me what's up with my Dsp file?

[DevTKSS]

I just looked throug my current diff of my repo locally and discovered this changes 🤔

I did not do anything in my apps colors but it seems like there is something happening.
I would be really interested in any information about this as my knowledge to the dsp is not very much but my other repo does have a known theme related issue, so it would not be so far away to think that this might be caused from that.
DevTKSS/DevTKSS.Uno.SampleApps#13

[kazo0]

I might be wrong but it looks like there's no actual functional change here, it's just reordering the resources for some reason, correct?

[DevTKSS]

yes, I would think that too, but I also noticed, that movement as Ludwig mentiones it, that there are indeed changes, I would potentially expect to cause issues on runtime 🤔

• "OnSurfaceInverseColor" casing ln58 -> OnsurfaceInverseColor ln61 => Which is indeed exactly THAT color which messes up at my MvuxGallery 😨 🤔 well... not just that... Am I went completly dump, or did it just move this key up to the Light ResourceDictionary?

Please check:

Before:

-<!-- This file is generated by a tool from the file ColorPaletteOverride.zip - - YOU SHOULD NOT EDIT IT manually.-->
<ResourceDictionary xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
  <ResourceDictionary.ThemeDictionaries>
    <ResourceDictionary x:Key="Light">
      <Color x:Key="PrimaryColor">#5946D2</Color>
      <Color x:Key="OnPrimaryColor">#FFFFFF</Color>
      <Color x:Key="PrimaryContainerColor">#E5DEFF</Color>
      <Color x:Key="OnPrimaryContainerColor">#170065</Color>
      <Color x:Key="SecondaryColor">#6B4EA2</Color>
      <Color x:Key="OnSecondaryColor">#FFFFFF</Color>
      <Color x:Key="SecondaryContainerColor">#EBDDFF</Color>
      <Color x:Key="OnSecondaryContainerColor">#220555</Color>
      <Color x:Key="TertiaryColor">#0061A4</Color>
      <Color x:Key="OnTertiaryColor">#FFFFFF</Color>
      <Color x:Key="TertiaryContainerColor">#CFE4FF</Color>
      <Color x:Key="OnTertiaryContainerColor">#001D36</Color>
      <Color x:Key="ErrorColor">#B3261E</Color>
      <Color x:Key="ErrorContainerColor">#F9DEDC</Color>
      <Color x:Key="OnErrorColor">#FFFFFF</Color>
-      <Color x:Key="OnErrorContainerColor">#410E0B</Color>
      <Color x:Key="BackgroundColor">#FCFBFF</Color>
      <Color x:Key="OnBackgroundColor">#1C1B1F</Color>
      <Color x:Key="SurfaceColor">#FFFFFF</Color>
      <Color x:Key="OnSurfaceColor">#1C1B1F</Color>
      <Color x:Key="SurfaceVariantColor">#F2EFF5</Color>
      <Color x:Key="OnSurfaceVariantColor">#8B8494</Color>
      <Color x:Key="OutlineColor">#79747E</Color>
-     <Color x:Key="OnSurfaceInverseColor">#F4EFF4</Color>
-     <Color x:Key="SurfaceInverseColor">#313033</Color>
-     <Color x:Key="PrimaryInverseColor">#C8BFFF</Color>
-     <Color x:Key="SurfaceTintColor">#5946D2</Color>
      <Color x:Key="OutlineVariantColor">#C9C5D0</Color>
    </ResourceDictionary>
    <ResourceDictionary x:Key="Dark">
      <Color x:Key="PrimaryColor">#C7BFFF</Color>
      <Color x:Key="OnPrimaryColor">#2A009F</Color>
      <Color x:Key="PrimaryContainerColor">#4129BA</Color>
      <Color x:Key="OnPrimaryContainerColor">#E4DFFF</Color>
      <Color x:Key="SecondaryColor">#CDC2DC</Color>
      <Color x:Key="OnSecondaryColor">#332D41</Color>
      <Color x:Key="SecondaryContainerColor">#433C52</Color>
      <Color x:Key="OnSecondaryContainerColor">#EDDFFF</Color>
      <Color x:Key="TertiaryColor">#9FCAFF</Color>
      <Color x:Key="OnTertiaryColor">#003258</Color>
      <Color x:Key="TertiaryContainerColor">#00497D</Color>
      <Color x:Key="OnTertiaryContainerColor">#D1E4FF</Color>
      <Color x:Key="ErrorColor">#FFB4AB</Color>
      <Color x:Key="ErrorContainerColor">#93000A</Color>
-     <Color x:Key="OnErrorColor">#690005</Color>
      <Color x:Key="OnErrorContainerColor">#FFDAD6</Color>
      <Color x:Key="BackgroundColor">#1C1B1F</Color>
      <Color x:Key="OnBackgroundColor">#E5E1E6</Color>
      <Color x:Key="SurfaceColor">#302D37</Color>
      <Color x:Key="OnSurfaceColor">#E6E1E5</Color>
      <Color x:Key="SurfaceVariantColor">#47464F</Color>
      <Color x:Key="OnSurfaceVariantColor">#C9C5D0</Color>
      <Color x:Key="OutlineColor">#928F99</Color>
-      <Color x:Key="OnSurfaceInverseColor">#1C1B1F</Color>
      <Color x:Key="SurfaceInverseColor">#E6E1E5</Color>
      <Color x:Key="PrimaryInverseColor">#2A009F</Color>
-      <Color x:Key="SurfaceTintColor">#C7BFFF</Color>
-      <Color x:Key="OutlineVariantColor">#57545D</Color>
    </ResourceDictionary>
  </ResourceDictionary.ThemeDictionaries>
</ResourceDictionary>

And After:

+<!-- This file is generated by a tool from the file ColorPaletteOverride.json - - YOU SHOULD NOT EDIT IT manually.-->
<ResourceDictionary xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
  <ResourceDictionary.ThemeDictionaries>
    <ResourceDictionary x:Key="Light">
      <Color x:Key="PrimaryColor">#5946D2</Color>
+      <Color x:Key="SurfaceTintColor">#5946D2</Color>
      <Color x:Key="OnPrimaryColor">#FFFFFF</Color>
      <Color x:Key="PrimaryContainerColor">#E5DEFF</Color>
      <Color x:Key="OnPrimaryContainerColor">#170065</Color>
      <Color x:Key="SecondaryColor">#6B4EA2</Color>
      <Color x:Key="OnSecondaryColor">#FFFFFF</Color>
      <Color x:Key="SecondaryContainerColor">#EBDDFF</Color>
      <Color x:Key="OnSecondaryContainerColor">#220555</Color>
      <Color x:Key="TertiaryColor">#0061A4</Color>
      <Color x:Key="OnTertiaryColor">#FFFFFF</Color>
      <Color x:Key="TertiaryContainerColor">#CFE4FF</Color>
      <Color x:Key="OnTertiaryContainerColor">#001D36</Color>
      <Color x:Key="ErrorColor">#B3261E</Color>
      <Color x:Key="OnErrorColor">#FFFFFF</Color>
+     <Color x:Key="ErrorContainerColor">#F9DEDC</Color>
      <Color x:Key="OnErrorContainerColor">#410E0B</Color>
      <Color x:Key="BackgroundColor">#FCFBFF</Color>
      <Color x:Key="OnBackgroundColor">#1C1B1F</Color>
      <Color x:Key="SurfaceColor">#FFFFFF</Color>
      <Color x:Key="OnSurfaceColor">#1C1B1F</Color>
      <Color x:Key="SurfaceVariantColor">#F2EFF5</Color>
      <Color x:Key="OnSurfaceVariantColor">#8B8494</Color>
      <Color x:Key="OutlineColor">#79747E</Color>
      <Color x:Key="OutlineVariantColor">#C9C5D0</Color>
+      <Color x:Key="SurfaceInverseColor">#E6E1E5</Color>
+      <Color x:Key="OnsurfaceInverseColor">#1C1B1F</Color>
+      <Color x:Key="PrimaryInverseColor">#2A009F</Color>
    </ResourceDictionary>
    <ResourceDictionary x:Key="Dark">
      <Color x:Key="PrimaryColor">#C7BFFF</Color>
+      <Color x:Key="SurfaceTintColor">#C7BFFF</Color>
      <Color x:Key="OnPrimaryColor">#2A009F</Color>
      <Color x:Key="PrimaryContainerColor">#4129BA</Color>
      <Color x:Key="OnPrimaryContainerColor">#E4DFFF</Color>
      <Color x:Key="SecondaryColor">#CDC2DC</Color>
      <Color x:Key="OnSecondaryColor">#332D41</Color>
      <Color x:Key="SecondaryContainerColor">#433C52</Color>
      <Color x:Key="OnSecondaryContainerColor">#EDDFFF</Color>
      <Color x:Key="TertiaryColor">#9FCAFF</Color>
      <Color x:Key="OnTertiaryColor">#003258</Color>
      <Color x:Key="TertiaryContainerColor">#00497D</Color>
      <Color x:Key="OnTertiaryContainerColor">#D1E4FF</Color>
      <Color x:Key="ErrorColor">#FFB4AB</Color>
+      <Color x:Key="OnErrorColor">#690005</Color>
      <Color x:Key="ErrorContainerColor">#93000A</Color>
      <Color x:Key="OnErrorContainerColor">#FFDAD6</Color>
      <Color x:Key="BackgroundColor">#1C1B1F</Color>
      <Color x:Key="OnBackgroundColor">#E5E1E6</Color>
      <Color x:Key="SurfaceColor">#302D37</Color>
      <Color x:Key="OnSurfaceColor">#E6E1E5</Color>
      <Color x:Key="SurfaceVariantColor">#47464F</Color>
      <Color x:Key="OnSurfaceVariantColor">#C9C5D0</Color>
      <Color x:Key="OutlineColor">#928F99</Color>
+      <Color x:Key="OutlineVariantColor">#57545D</Color>
      <Color x:Key="SurfaceInverseColor">#E6E1E5</Color>
+     <Color x:Key="OnsurfaceInverseColor">#1C1B1F</Color>
      <Color x:Key="PrimaryInverseColor">#2A009F</Color>
    </ResourceDictionary>
  </ResourceDictionary.ThemeDictionaries>
</ResourceDictionary>

[DevTKSS]

🤔 well... so the color thats the MvuxGallery problem is "SurfaceInverseBrush" which does not listen on ThemeChange not the one with the Casing Problem:

https://technischekonstruktion-my.sharepoint.com/:v:/g/personal/info_technische-konstruktion_com/EfRObBUVghVKk-LfTXlAQlIBjZgWceUHhgHdQB8VKUMR-g?e=tgq7Ky

But also it seems like I also found some HD problem :( again...
While HD showed the update correctly in Hot Reload this is not updated? so HD might not be able to update ResourceDictionary...
and intellisense accepted completion does not preserve the ms-appx:/// Path prefix...
but thats not solving the HD update. would have been to good to be true...

https://technischekonstruktion-my.sharepoint.com/:v:/g/personal/info_technische-konstruktion_com/EWRm1_nIGfxDrebGjTubg-IB9QkQu2cBzNg5dzI7p1i2FQ?e=tlcjmH

Dump question, but... The Background Property of for example grid or TextBox, do they support Themes? Seems like not? As soon as I delete the color in that, this UI part does again switch color...
Its always the first member layer coming from a ResourceDictionary, that does not update color?

thats surprising discovery... so if I would define any element below that, with a Background and put then this one above it... would my Grid then respect the Theme Change?

link to commit with changes if somone want to see it:
DevTKSS/DevTKSS.Uno.SampleApps@4f9f3a7

(Added the existing issue related Information to the Issue on the Repo itself)

[DevTKSS]

@kazo0 checking the issue status of my linked uno issue, it seems like those on uno side has been closed? Do I miss a still opened issue or do I need to open a new one? using the latest stable uno.sdk, while the issue I had linked states it would be fixed with 6.1.0-dev (some number) on the chefs app for example, so 6.1.23 should then have those fixes applyed from versioning seen, or am I missing something?

[kazo0]

@DevTKSS sorry which issue are you referring to? I can't seem to find a link to an Uno issue here. If the fix is not in 6.1.23, it will be included in 6.2 and probably in the latest 6.2.0-dev Sdk if the changes were already merged

[DevTKSS]

@kazo0 ah I see, then I think those did just not go into release until now 👍

To your question as explaination: I have an Issue on my Repo here DevTKSS/DevTKSS.Uno.SampleApps#13 to the theme change problem. Indeed, I did primary yesterday discover, that I need to add a "-" infront of an issue link to get GH providing a state of it, 😄so I did not notice until then that this had been closed 😅 I think, as you saying this would be expected to be merged as fix in the 6.2 I'll just keep that open till then. Dont know if it is possible on GH to have a note like on PR or Issues that would show up on that link for that time then to check the issue again 🤔

BUT that Issue is not about this strange casing thing I did see here on comparing that diff 🤔 as its a generated file and I do not have any knowledge about generated contents like this, I dont know if I need to open one for this, can you tell me?

On Sashas Request I did create last days a follow-up "EPIC" Issue on my both main Repos:

• [EPIC][Uno Platform] Open Issues / Discussions / Requests on Uno Repositorys DevTKSS/DevTKSS.Uno.SampleApps#16
  and both and the issues open so far on my side which are following up are also available in my Project here:
• @DevTKSS Bug Tracker (view)

I do not have so far an issue per point in the Epic list, but linked most of the open ones that causing me trouble or blocking me there.