Add benchmarking setup #25
Conversation
There was a problem hiding this comment.
Copilot reviewed 101 out of 108 changed files in this pull request and generated 4 comments.
Files not reviewed (7)
- datex-language/datex.tmLanguage.json: Language not supported
- datex-language/datex.tmbundle/info.plist: Language not supported
- datex-language/example.dx: Language not supported
- docs/diagrams/d2/architecture-overview.d2: Language not supported
- docs/diagrams/d2/com-hub-process.d2: Language not supported
- docs/diagrams/d2/com-hub-structure.d2: Language not supported
- docs/diagrams/d2/endpoint-structure.d2: Language not supported
| const { code } = await process.output(); | ||
| if (code !== 0) { | ||
| const { stderr } = await process.output(); | ||
| console.error(`Error rendering ${inputFile}: ${new TextDecoder().decode(stderr)}`); |
There was a problem hiding this comment.
process.output() is called twice, which may re-run the command and produce inconsistent output. Consider storing the result of process.output() in a variable and reusing it for error handling.
| const { code } = await process.output(); | |
| if (code !== 0) { | |
| const { stderr } = await process.output(); | |
| console.error(`Error rendering ${inputFile}: ${new TextDecoder().decode(stderr)}`); | |
| const output = await process.output(); | |
| if (output.code !== 0) { | |
| console.error(`Error rendering ${inputFile}: ${new TextDecoder().decode(output.stderr)}`); |
Copilot uses AI. Check for mistakes.
|
|
||
| ## Contributing | ||
|
|
||
| We welcome every contribution!<br> | ||
| Please take a look at the [development guidelines](./DEVELOP.md) and the unyt.org [contribution guidlines](https://github.com/unyt-org/.github/blob/main/CONTRIBUTING.md). | ||
| Please take a look at the [development guidelines](./DEVELOP.md) and the | ||
| unyt.org [contribution guidlines](https://github.com/unyt-org/.github/blob/main/CONTRIBUTING.md). |
There was a problem hiding this comment.
Typo detected: 'contribution guidlines' should be 'contribution guidelines'.
| unyt.org [contribution guidlines](https://github.com/unyt-org/.github/blob/main/CONTRIBUTING.md). | |
| unyt.org [contribution guidelines](https://github.com/unyt-org/.github/blob/main/CONTRIBUTING.md). |
Copilot uses AI. Check for mistakes.
| ] # default to nostd | ||
| native_websocket = ["websocket"] # use native websocket | ||
| native_tcp = [] # use native tcp | ||
| native_rand = ["rand"] # use native websocket |
There was a problem hiding this comment.
Comment mismatch: 'use native websocket' should be updated to 'use native rand'.
| native_rand = ["rand"] # use native websocket | |
| native_rand = ["rand"] # use native rand |
Copilot uses AI. Check for mistakes.
| native_websocket = ["websocket"] # use native websocket | ||
| native_tcp = [] # use native tcp | ||
| native_rand = ["rand"] # use native websocket | ||
| native_uuid = ["uuid"] # use native websocket |
There was a problem hiding this comment.
Comment mismatch: 'use native websocket' should be updated to 'use native uuid'.
| native_uuid = ["uuid"] # use native websocket | |
| native_uuid = ["uuid"] # use native uuid |
Copilot uses AI. Check for mistakes.
|
Bencher Report| Branch | feat/benchmarking |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | milliseconds (ms) |
|---|---|---|
| runtime init | 📈 view plot 🚷 view threshold | 1.05 ms |
No description provided.