This repository was archived by the owner on Aug 3, 2022. It is now read-only.
update small button size and deprecate the xs one #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phndiaye
requested review from
JulienVannier66,
Miexil and
a team
as code owners
phndiaye
force-pushed
the
pn/backlog-1705/update-btn-small-height
branch
from
e8b6b51 to
eac5dd4
Compare
Miexil
reviewed
Jun 24, 2022
less/base/_buttons.less
Outdated
| @@ -353,15 +353,14 @@ as size modifiers. | |||
| // -------------------------------------------------- | |||
|
|
|||
| .upf-btn--small, .upf-btn--sm { | |||
| height: @input-size-sm; | |||
| height: 24px; | |||
Miexil
approved these changes
Jun 24, 2022
JulienVannier66
approved these changes
Jun 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the height of the button's size small and deprecate the
xsone.Related to : https://github.com/upfluence/backlog/issues/1705
What are the observable changes?
Good PR checklist
Additional Notes