Add regex for generic jquery detection in primefaces web applications #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am currently testing a web application which is using the Java UI framework Primefaces. In Primefaces the import of JQuery does look a little bit different. Currently Whatweb is not able to detect the version.
I have created a new regular expression for the JQuery version detection in Primefaces. The import looks like the following:
src="/javax.faces.resource/jquery/jquery.js.xhtml?ln=primefaces&v=6.2.12"The new regex is written in a way that is able to detect the JQuery version not only in Primefaces but also in other possible formats.
Let me know what you think about the new regex.
Best regards
Manuel