Add tests for ResponseSize component #4676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naman-bruno
reviewed
May 21, 2025
packages/bruno-app/package.json
Outdated
| "mini-css-extract-plugin": "^2.4.5", | ||
| "postcss": "8.4.47", | ||
| "style-loader": "^3.3.1", | ||
| "styled-components": "^6.1.18", |
There was a problem hiding this comment.
Could you please move styled-components from devDependencies to dependencies and revert it back to version 5.3.3, which is the version we're currently using?
naman-bruno
requested changes
May 22, 2025
packages/bruno-app/jest.config.js
Outdated
| projects: [ | ||
| { | ||
| displayName: 'DOM', | ||
| testMatch: ['<rootDir>/src/components/**/*.(spec|test).[jt]s?(x)'], |
There was a problem hiding this comment.
Change to /**/*.{spec,test}.[jt]s?(x) parentheses syntax is incorrect for globs
packages/bruno-app/jest.config.js
Outdated
| }, | ||
| { | ||
| displayName: 'NODE', | ||
| testMatch: ['<rootDir>/src/**/*.(spec|test).[jt]s?(x)'], |
There was a problem hiding this comment.
Change to /**/*.{spec,test}.[jt]s?(x) parentheses syntax is incorrect for globs
|
Closing the PR since there was a problem in the build with the branch. See new PR here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.