Ush 1587 - Add 3 new media types on the backend #5004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushahidlee
changed the title
Mh-Asmi
approved these changes
Oct 24, 2024
| @@ -35,7 +35,7 @@ protected function isSupported(Command $command) | |||
| public function __invoke(Action $action) | |||
| { | |||
| $this->isSupported($action); | |||
| $this->validateFileData($action->getMediaEntity()); | |||
| // $this->validateFileData($action->getMediaEntity()); | |||
There was a problem hiding this comment.
I don't think is good idea to stop all validations.
at least we need to keep the size validation
There was a problem hiding this comment.
I am disabling this because it presents a hard upload limit which is in opposition to the frontend functionality. I will be creating a new ticket for changes to the backend to handle the frontend functionality, and in the interim have implemented validation on the frontend.
tuxpiper
reviewed
Oct 31, 2024
|
|
||
| use Phinx\Migration\AbstractMigration; | ||
|
|
||
| class EmbiggenMimeType extends AbstractMigration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
We need 3 new media fields on the backend: image, document and audio. These fields should be able to handle an array of values.
Testing:
Fields of type 'media' with inputs 'image', 'document' or 'audio' work as expected accepting multiple values into each.