Skip to content

Commit 843ade4

Browse files
committed
update readme now that build process include correct metadata
1 parent a1c6d13 commit 843ade4

File tree

5 files changed

+49
-39
lines changed

5 files changed

+49
-39
lines changed

.github/workflows/release-verifier.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
- name: Install build dependencies
2929
run: |
3030
sudo apt-get update
31-
sudo apt-get install -y binaryen
31+
sudo apt-get install -y jq
3232
cargo install --locked wasi2ic candid-extractor ic-wasm
3333
3434
- name: Install DFX

Cargo.lock

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ members = [
1414
resolver = "2"
1515

1616
[workspace.package]
17-
version = "0.2.6-rc.6"
17+
version = "0.2.6"
1818
authors = ["Usher Labs <labs@usher.so>"]
1919
repository = "https://github.com/usherlabs/verity-dp"
2020
homepage = "https://www.usher.so/"

ic/canisters/asset_manager/Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ic/managed/verifier/README.md

Lines changed: 38 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,36 @@
1-
# Verity Managed *General Purpose MPC-TLS* Verifier
1+
# Verity Managed *General-purpose MPC-TLS* Verifier
22

3-
To learn about the Verity Verifier in detail, please refer to the [official documentation](https://docs.verity.usher.so/), specifically the [Verity Verifier](https://docs.verity.usher.so/build/verifier) section.
3+
For detailed information about the Verity Verifier, see the [official documentation](https://docs.verity.usher.so/), specifically the [Verity Verifier](https://docs.verity.usher.so/build/verifier) section.
44

5-
**The following is from the documentation as of *23 January 2025*.**
5+
**The following content reflects the documentation as at 23 January 2025.**
6+
7+
## Use the Verifier as a Dependency in Your Canister
8+
9+
The Verifier can now be used as a dependency in other canisters.
10+
11+
Update your `dfx.json` to include:
12+
13+
```json
14+
{
15+
"canisters": {
16+
"<your_canister>": {
17+
.....
18+
"dependencies": [
19+
"verity_verifier"
20+
]
21+
},
22+
"verity_verifier": {
23+
"type": "pull",
24+
"id": "yf57k-fyaaa-aaaaj-azw2a-cai"
25+
}
26+
}
27+
}
28+
29+
```
630

731
## Local Deployment
832

9-
**Disclaimer:** Deployment of the canister (`ic/managed/verifier`) to mainnet is not recommended. This is to ensure compliance with licence agreements and to maintain compatibility and security with the broader Verity Network. We recommend using our Managed *General Purpose MPC-TLS* Verifier and interfacing via an inter-canister `async` calls or a wallet‑to‑IC `direct` calls for optimal security and performance.
33+
**Disclaimer:** Deployment of this canister (`ic/managed/verifier`) to the mainnet is not recommended. This is to ensure compliance with licence agreements and to maintain compatibility and security across the broader Verity Network. We recommend using our managed *General-purpose MPC-TLS* Verifier and interfacing via intercanister `async` calls or wallet‑to‑IC `direct` calls for optimal security and performance.
1034

1135
### Prerequisites
1236

@@ -16,26 +40,12 @@ To learn about the Verity Verifier in detail, please refer to the [official docu
1640
rustup target add wasm32-wasip1
1741
```
1842

19-
2. Install `wasi2ic`:
43+
2. Install `wasi2ic`, `candid-extractor`, and `ic-wasm`:
2044

2145
```bash
22-
cargo install wasi2ic
46+
cargo install wasi2ic candid-extractor ic-wasm
2347
```
2448

25-
3. Install `binaryen`:
26-
27-
With Homebrew:
28-
29-
```bash
30-
brew install binaryen
31-
```
32-
33-
From the releases page:
34-
1. Download [Binaryen](https://github.com/WebAssembly/binaryen/releases) from the releases page.
35-
2. Extract the files: `tar -xzf binaryen-version.tar.gz`.
36-
3. Move the binary to your PATH: `sudo mv binaryen-version/bin/wasm-opt /usr/local/bin/`.
37-
4. Verify the installation: `wasm-opt --version`.
38-
3949
### Deployment
4050

4151
To deploy the canister locally, follow these steps:
@@ -48,25 +58,25 @@ To deploy the canister locally, follow these steps:
4858
1. `pnpm prep`
4959
2. `pnpm test --run`
5060

51-
### Performance benchmarks
61+
### Performance Benchmarks
5262

5363
We have benchmarked the following functions to provide insight into their performance:
5464

5565
#### `verify_proof_async` and `verify_proof_async_batch`
5666

57-
- **Execution time:** Constant, regardless of input size (~2100 ms).
67+
- **Execution time:** Constant, regardless of input size (≈ 2,100 ms).
5868
- **DFX cycle cost:** Approximately 550–720 cycles per byte of TLS data.
5969

6070
#### `verify_proof_direct` and `verify_proof_direct_batch`
6171

62-
- **Execution time:** Linear; approximately 3× the execution time of `verify_proof_async` plus signing time (L).
72+
- **Execution time:** Approximately linear; about 3× the execution time of `verify_proof_async`, plus signing time.
6373
- **DFX cycle cost:** Roughly the same as `verify_proof_async` and `verify_proof_async_batch`.
6474

6575
### Caveats
6676

67-
#### `clang` dependency
77+
#### Clang dependency
6878

69-
**On macOS:** If you experience issues during `cargo build` where the `ring` library fails to compile, this is typically because `clang` is not found.
79+
**On macOS:** If you encounter issues during `cargo build` where the `ring` library fails to compile, it is typically because `clang` is not found.
7080

7181
To resolve this:
7282

@@ -82,12 +92,12 @@ brew install llvm
8292
echo 'PATH="$(brew --prefix llvm)/bin${PATH:+:${PATH}}"; export PATH;' >> ~/.zshrc
8393
```
8494

85-
#### `etherum_pk`
95+
#### `etherum_pk` (typo)
8696

87-
The `etherum_pk` field in the `PublicKeyReply` struct is the Ethereum address derived from the SEC1 public key. This is obtained using the `get_address_from_public_key` function in the `ethereum` module.
97+
The `etherum_pk` field in the `PublicKeyReply` struct is the Ethereum address derived from the SEC1 public key. It is obtained using the `get_address_from_public_key` function in the `ethereum` module.
8898

8999
```rust
90100
let address = ethereum::get_address_from_public_key(res.public_key.clone()).expect("INVALID_PUBLIC_KEY");
91101
```
92102

93-
*It should be spelled `ethereum_pk`, not `etherum_pk`.*
103+
Note: The correct field name is `ethereum_pk`, not `etherum_pk`.

0 commit comments

Comments
 (0)