Skip to content

Commit 3fd8246

Browse files
committed
Renames
1 parent 2cc8f49 commit 3fd8246

19 files changed

+186
-190
lines changed

src/api/language/gdj_language.cpp

+8-8
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
#include "gdj_language.h"
22

3-
#include "gd_kotlin.h"
3+
#include "api/script/jvm_script_manager.h"
4+
#include "api/script/language/gdj_script.h"
5+
#include "godot_jvm.h"
46
#include "jvm/wrapper/memory/memory_manager.h"
57
#include "lifecycle/paths.h"
68
#include "names.h"
7-
#include "api/script/jvm_script_manager.h"
8-
#include "api/script/language/gdj_script.h"
99

1010
constexpr const char* GDJ_TEMPLATE = "// GENERATED BY THE GODOT EDITOR. DON'T FORGET TO CREATE A CORRESPONDING SOURCE "
1111
"FILE! OTHERWISE THIS FILE WILL BE DELETED UPON NEXT BUILD.\n"
@@ -27,23 +27,23 @@ GdjLanguage* GdjLanguage::get_instance() {
2727
}
2828

2929
void GdjLanguage::init() {
30-
GDKotlin::get_instance().initialize_up_to(GDKotlin::State::JVM_SCRIPTS_INITIALIZED);
30+
GodotJvm::get_instance().initialize_up_to(GodotJvm::State::JVM_SCRIPTS_INITIALIZED);
3131

3232
#ifdef DEBUG_ENABLED
33-
GDKotlin::get_instance().validate_state();
33+
GodotJvm::get_instance().validate_state();
3434
#endif
3535
}
3636

3737
void GdjLanguage::frame() {
38-
if (unlikely(GDKotlin::get_instance().state < GDKotlin::State::CORE_LIBRARY_INITIALIZED)) { return; }
39-
if (unlikely(GDKotlin::get_instance().user_configuration.disable_gc)) { return; }
38+
if (unlikely(GodotJvm::get_instance().state < GodotJvm::State::CORE_LIBRARY_INITIALIZED)) { return; }
39+
if (unlikely(GodotJvm::get_instance().user_configuration.disable_gc)) { return; }
4040

4141
jni::Env env {jni::Jvm::current_env()};
4242
MemoryManager::get_instance().sync_memory(env);
4343
}
4444

4545
void GdjLanguage::finish() {
46-
GDKotlin::get_instance().finalize_down_to(GDKotlin::State::NOT_STARTED);
46+
GodotJvm::get_instance().finalize_down_to(GodotJvm::State::NOT_STARTED);
4747
}
4848

4949
void GdjLanguage::thread_enter() {

src/api/resource_format/java_archive_resource_format_loader.cpp

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
#include "java_archive_resource_format_loader.h"
33

4-
#include "gd_kotlin.h"
4+
#include "godot_jvm.h"
55
#include "hash.h"
66
#include "java_archive.h"
77
#include "lifecycle/paths.h"
@@ -35,8 +35,7 @@ Ref<Resource> JavaArchiveFormatLoader::load(
3535
ref.instantiate();
3636

3737
#ifdef TOOLS_ENABLED
38-
if(p_path.ends_with(USER_CODE_FILE)){
39-
GDKotlin::get_instance().reload_user_code();
38+
if(p_path.ends_with(USER_CODE_FILE)){ GodotJvm::get_instance().reload_user_code();
4039
}
4140
#endif
4241

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
1-
#include "kotlin_binding.h"
2-
31
#include "jvm/wrapper/memory/type_manager.h"
2+
#include "jvm_binding.h"
43

5-
6-
void KotlinBinding::init(Object* p_object) {
4+
void JvmBinding::init(Object* p_object) {
75
StringName class_name {p_object->get_class_name()};
86
do {
97
if (!TypeManager::get_instance().java_engine_type_constructor_for_type_exists(class_name)) {
@@ -15,11 +13,11 @@ void KotlinBinding::init(Object* p_object) {
1513
constructor_id = TypeManager::get_instance().get_java_engine_type_constructor_index_for_type(class_name);
1614
}
1715

18-
int KotlinBinding::get_constructor_id() const{
16+
int JvmBinding::get_constructor_id() const{
1917
return constructor_id;
2018
}
2119

22-
bool KotlinBinding::test_and_set_incremented() {
20+
bool JvmBinding::test_and_set_incremented() {
2321
// Set to true and return the previous value.
2422
return is_incremented.test_and_set(std::memory_order_acq_rel);
2523
}
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
1-
#ifndef GODOT_JVM_KOTLIN_BINDING_H
2-
#define GODOT_JVM_KOTLIN_BINDING_H
1+
#ifndef GODOT_JVM_JVM_BINDING_H
2+
#define GODOT_JVM_JVM_BINDING_H
33

44
#include "jvm_wrapper/registration/kt_object.h"
55
#include <atomic>
66

7-
class KotlinBinding {
7+
class JvmBinding {
88
int constructor_id = -1;
99
// Using std directly because Godot SafeFlag doesn't provide the right methods (despite wrapping the same std atomic).
1010
std::atomic_flag is_incremented = ATOMIC_FLAG_INIT;
1111
public:
12-
KotlinBinding() = default;
13-
~KotlinBinding() = default;
12+
JvmBinding() = default;
13+
~JvmBinding() = default;
1414

1515
void init(Object* obj);
1616
int get_constructor_id() const;
1717
bool test_and_set_incremented();
1818
};
1919

20-
#endif// GODOT_JVM_KOTLIN_BINDING_H
20+
#endif // GODOT_JVM_JVM_BINDING_H
Original file line numberDiff line numberDiff line change
@@ -1,60 +1,59 @@
1-
#include "kotlin_binding_manager.h"
2-
3-
#include "gd_kotlin.h"
1+
#include "godot_jvm.h"
42
#include "jvm/wrapper/memory/memory_manager.h"
3+
#include "jvm_binding_manager.h"
54

6-
GDExtensionInstanceBindingCallbacks KotlinBindingManager::_instance_binding_callbacks = {
5+
GDExtensionInstanceBindingCallbacks JvmBindingManager::_instance_binding_callbacks = {
76
&_instance_binding_create_callback,
87
&_instance_binding_free_callback,
98
nullptr
109
};
1110

12-
void* KotlinBindingManager::_instance_binding_create_callback(void* p_token, void* p_instance) {
13-
KotlinBinding* binding = memnew(KotlinBinding);
11+
void* JvmBindingManager::_instance_binding_create_callback(void* p_token, void* p_instance) {
12+
JvmBinding* binding = memnew(JvmBinding);
1413
binding->init(reinterpret_cast<godot::Object*>(p_instance));
1514

1615
return binding;
1716
}
1817

19-
void KotlinBindingManager::_instance_binding_free_callback(void* p_token, void* p_instance, void* p_binding) {
18+
void JvmBindingManager::_instance_binding_free_callback(void* p_token, void* p_instance, void* p_binding) {
2019
// Called in the destructor of the Object.
2120
// It's the very last action done in the destructor so assume variables local to the Object have been cleaned (including script and extension).
2221
// There are 2 cases, either an Object has been freed, and we have to release its reference OR it's a RefCounted and the JVM instance is already dead.
2322

24-
godot::memdelete(reinterpret_cast<KotlinBinding*>(p_binding));
23+
godot::memdelete(reinterpret_cast<JvmBinding*>(p_binding));
2524

2625
godot::Object* object = reinterpret_cast<godot::Object*>(p_instance);
2726
if (!object->is_ref_counted()) { MemoryManager::get_instance().queue_dead_object(object); }
2827
}
2928

30-
KotlinBinding* KotlinBindingManager::set_instance_binding(godot::Object* p_object) {
29+
JvmBinding* JvmBindingManager::set_instance_binding(godot::Object* p_object) {
3130
// Godot being weird. Call this function only if the JVM is the creator of the object, otherwise it will crash in case the object has any other bindings.
3231
// If not the creator (When you want to bind an existing object to JVM), use get_instance_binding instead.
3332

34-
KotlinBinding* binding = memnew(KotlinBinding);
33+
JvmBinding* binding = memnew(JvmBinding);
3534
binding->init(p_object);
3635

3736
if (p_object->is_ref_counted()) {
3837
reinterpret_cast<godot::RefCounted*>(p_object)->init_ref();
3938
binding->test_and_set_incremented();
4039
}
41-
p_object->set_instance_binding(&GDKotlin::get_instance(), binding, &_instance_binding_callbacks);
40+
p_object->set_instance_binding(&GodotJvm::get_instance(), binding, &_instance_binding_callbacks);
4241

4342
return binding;
4443
}
4544

46-
KotlinBinding* KotlinBindingManager::get_instance_binding(godot::Object* p_object) {
45+
JvmBinding* JvmBindingManager::get_instance_binding(godot::Object* p_object) {
4746
// Godot being weird but this is how you create a binding if it doesn't exist already, otherwise just retrieve it.
4847
// Use this function to bind an existing object to the JVM, the callbacks provided will handle the creation of the binding.
49-
KotlinBinding* binding =
50-
reinterpret_cast<KotlinBinding*>(p_object->get_instance_binding(&GDKotlin::get_instance(), &_instance_binding_callbacks));
48+
JvmBinding* binding =
49+
reinterpret_cast<JvmBinding*>(p_object->get_instance_binding(&GodotJvm::get_instance(), &_instance_binding_callbacks));
5150

5251
if (p_object->is_ref_counted() && !binding->test_and_set_incremented()) {
5352
reinterpret_cast<godot::RefCounted*>(p_object)->reference();
5453
}
5554
return binding;
5655
}
5756

58-
void KotlinBindingManager::free_binding(godot::Object* p_ref) {
59-
p_ref->free_instance_binding(&GDKotlin::get_instance());
57+
void JvmBindingManager::free_binding(godot::Object* p_ref) {
58+
p_ref->free_instance_binding(&GodotJvm::get_instance());
6059
}
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,17 @@
1-
#ifndef GODOT_JVM_KOTLIN_BINDING_MANAGER_H
2-
#define GODOT_JVM_KOTLIN_BINDING_MANAGER_H
1+
#ifndef GODOT_JVM_JVM_BINDING_MANAGER_H
2+
#define GODOT_JVM_JVM_BINDING_MANAGER_H
3+
4+
#include "jvm_binding.h"
35

46
#include <gdextension_interface.h>
5-
#include <classes/object.hpp>
6-
#include "kotlin_binding.h"
77

8+
#include <classes/object.hpp>
89
#include <cstdint>
910

10-
class KotlinBindingManager {
11-
KotlinBindingManager() = default;
11+
class JvmBindingManager {
12+
JvmBindingManager() = default;
1213

13-
~KotlinBindingManager() = default;
14+
~JvmBindingManager() = default;
1415

1516
// Callbacks required by Godot for instance bindings.
1617
static GDExtensionInstanceBindingCallbacks _instance_binding_callbacks;
@@ -20,17 +21,17 @@ class KotlinBindingManager {
2021
static void _instance_binding_free_callback(void* p_token, void* p_instance, void* p_binding);
2122

2223
public:
23-
KotlinBindingManager(KotlinBindingManager const& other) = delete;
24+
JvmBindingManager(JvmBindingManager const& other) = delete;
2425

25-
KotlinBindingManager& operator=(const KotlinBindingManager&) = delete;
26+
JvmBindingManager& operator=(const JvmBindingManager&) = delete;
2627

2728
// For instance bindings, they are to bind native Godot objects to their JVM wrappers, not for the scripts.
28-
static KotlinBinding* set_instance_binding(godot::Object* p_object);
29+
static JvmBinding* set_instance_binding(godot::Object* p_object);
2930

3031
// Doesn't set the KtObject as it doesn't exist yet, bind_object has be used later.
31-
static KotlinBinding* get_instance_binding(godot::Object* p_object);
32+
static JvmBinding* get_instance_binding(godot::Object* p_object);
3233

3334
static void free_binding(godot::Object* p_ref);
3435
};
3536

36-
#endif// GODOT_JVM_KOTLIN_BINDING_MANAGER_H
37+
#endif // GODOT_JVM_JVM_BINDING_MANAGER_H

src/editor/export/kotlin_editor_export_plugin.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22

33
#include "kotlin_editor_export_plugin.h"
44

5-
#include "gd_kotlin.h"
65
#include "api/language/names.h"
6+
#include "api/script/jvm_script_manager.h"
7+
#include "godot_jvm.h"
78
#include "lifecycle/jvm_user_configuration.h"
89
#include "lifecycle/paths.h"
9-
#include "api/script/jvm_script_manager.h"
1010

1111
#include <core/config/project_settings.hpp>
1212

@@ -124,7 +124,7 @@ void KotlinEditorExportPlugin::_export_begin(const HashSet<String>& p_features,
124124

125125
// add Godot Kotlin/JVM configuration file based on export targets
126126
if (export_all) {
127-
_generate_export_configuration_file(GDKotlin::get_instance().get_configuration().vm_type);
127+
_generate_export_configuration_file(GodotJvm::get_instance().get_configuration().vm_type);
128128
} else if (export_jvm) {
129129
_generate_export_configuration_file(jni::JvmType::JVM);
130130
} else if (export_graal) {
@@ -163,7 +163,7 @@ void KotlinEditorExportPlugin::_export_begin(const HashSet<String>& p_features,
163163
}
164164

165165
void KotlinEditorExportPlugin::_generate_export_configuration_file(jni::JvmType vm_type) {
166-
JvmUserConfiguration configuration = GDKotlin::get_instance().get_configuration(); // Copy
166+
JvmUserConfiguration configuration = GodotJvm::get_instance().get_configuration(); // Copy
167167
configuration.vm_type = vm_type; // We only need to change the vm type
168168

169169
const char32_t* json_string {JvmUserConfiguration::export_configuration_to_json(configuration).get_data()};

src/editor/godot_kotlin_jvm_editor.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
#include "godot_kotlin_jvm_editor.h"
22

33
#include "editor/build/build_manager.h"
4+
#include "godot_jvm.h"
45
#include "lifecycle/paths.h"
56
#include "project/project_generator.h"
67
#include "strings.h"
78

89
#include <core/config/project_settings.hpp>
910
#include <editor/editor_interface.hpp>
1011
#include <editor/filesystem_dock.hpp>
11-
#include "gd_kotlin.h"
1212

1313
void GodotKotlinJvmEditor::on_menu_option_pressed(int option_id) {
1414
switch (option_id) {
@@ -38,13 +38,13 @@ void GodotKotlinJvmEditor::on_build_finished() {
3838
}
3939

4040
void GodotKotlinJvmEditor::on_filesystem_change() {
41-
if (GDKotlin::get_instance().state == GDKotlin::State::JVM_SCRIPTS_INITIALIZED) { return; }
41+
if (GodotJvm::get_instance().state == GodotJvm::State::JVM_SCRIPTS_INITIALIZED) { return; }
4242

4343
// We check for changes in the file system in case the main.jar has been added (not reloaded, just was not present when the editor started)
44-
if (GDKotlin::get_instance().state == GDKotlin::State::JVM_STARTED) {
44+
if (GodotJvm::get_instance().state == GodotJvm::State::JVM_STARTED) {
4545
String bootstrap {String(RES_DIRECTORY).path_join(BOOTSTRAP_FILE)};
4646
if (FileAccess::exists(bootstrap)) {
47-
GDKotlin::get_instance().initialize_up_to(GDKotlin::State::JVM_SCRIPTS_INITIALIZED);
47+
GodotJvm::get_instance().initialize_up_to(GodotJvm::State::JVM_SCRIPTS_INITIALIZED);
4848
}
4949
}
5050
}

src/gd_kotlin.h

-88
This file was deleted.

0 commit comments

Comments
 (0)