feat: Remove multi args constructor constraints and simplify code according to this modification

Author: piiertho

kt/api-generator/src/main/resources/api.json

@@ -5,7 +5,7 @@
 		"version_patch": 0,
 		"version_status": "stable",
 		"version_build": "custom_build",
-		"version_full_name": "Godot Engine v4.3.stable.custom_build"
+		"version_full_name": "Godot Engine v4.3.stable.jvm.0.11.0.custom_build"
 	},
 	"builtin_class_sizes": [
 		{
@@ -137072,10 +137072,10 @@
 				{
 					"name": "new",
 					"is_const": false,
-					"is_vararg": true,
+					"is_vararg": false,
 					"is_static": false,
 					"is_virtual": false,
-					"hash": 1545262638,
+					"hash": 1460262497,
 					"return_value": {
 						"type": "Variant"
 					},
@@ -243394,6 +243394,15 @@
 			"brief_description": "Editor-only helper for setting up root motion in [AnimationMixer].",
 			"description": "[i]Root motion[/i] refers to an animation technique where a mesh's skeleton is used to give impulse to a character. When working with 3D animations, a popular technique is for animators to use the root skeleton bone to give motion to the rest of the skeleton. This allows animating characters in a way where steps actually match the floor below. It also allows precise interaction with objects during cinematics. See also [AnimationMixer].\n[b]Note:[/b] [RootMotionView] is only visible in the editor. It will be hidden automatically in the running project."
 		},
+		{
+			"name": "ScalaScript",
+			"is_refcounted": true,
+			"is_instantiable": true,
+			"inherits": "JvmScript",
+			"api_type": "core",
+			"brief_description": "",
+			"description": ""
+		},
 		{
 			"name": "SceneMultiplayer",
 			"is_refcounted": true,

kt/common/src/main/kotlin/godot/common/constants/Constraints.kt

@@ -3,7 +3,6 @@ package godot.common.constants
 // when changed; also update constraints.h!
 // Since Godot 4, an unlimited amount of parameters is supported. Limits should be increased when appropriate.
 object Constraints {
-    const val MAX_CONSTRUCTOR_ARG_COUNT = 8
     const val MAX_FUNCTION_ARG_COUNT = 16
     const val MAX_SIGNAL_ARG_COUNT = 16
 }

kt/entry-generation/godot-class-graph-symbol-processor/src/main/kotlin/godot/annotation/processor/classgraph/extensions/ClassExtentions.kt

@@ -41,33 +41,18 @@ fun ClassInfo.mapToClazz(settings: Settings): Clazz {
         }
         .map { it.mapFieldToRegisteredSignal(settings, this) }
 
-    val duplicateConstructorArgumentCount = constructorInfo
-        .groupBy { it.parameterInfo.size }
-        .toList()
-        .firstOrNull { it.second.size > 1 }
-        ?.first
-
     val shouldBeRegistered = shouldBeRegistered(methods, fields, signals)
 
-    if (shouldBeRegistered && duplicateConstructorArgumentCount != null) {
-        throw Exception(
-            "Cannot have more than one constructor with $duplicateConstructorArgumentCount arguments in registered class $fqName"
-        )
-    }
-
-    val constructors = constructorInfo
-        .filter { constructor ->
-            constructor.isPublic && constructor.parameterInfo.isEmpty()
+    return if (shouldBeRegistered) {
+        require(constructorInfo.any { it.isPublic && it.parameterInfo.isEmpty() }) {
+            "You should provide a default constructor for class $fqName"
         }
-        .map { it.mapToRegisteredConstructor(settings) }
 
-    return if (shouldBeRegistered) {
         RegisteredClass(
             registeredName = provideRegisteredClassName(settings),
             fqName = fqName,
             supertypes = supertypes,
             annotations = annotations,
-            constructors = constructors,
             functions = methods,
             signals = signals,
             properties = fields,

kt/entry-generation/godot-class-graph-symbol-processor/src/main/kotlin/godot/annotation/processor/classgraph/extensions/MethodExtensions.kt

@@ -2,9 +2,7 @@ package godot.annotation.processor.classgraph.extensions
 
 import godot.annotation.processor.classgraph.Settings
 import godot.annotation.processor.classgraph.models.TypeDescriptor
-import godot.entrygenerator.model.ConstructorAnnotation
 import godot.entrygenerator.model.FunctionAnnotation
-import godot.entrygenerator.model.RegisteredConstructor
 import godot.entrygenerator.model.RegisteredFunction
 import io.github.classgraph.ClassInfo
 import io.github.classgraph.MethodInfo
@@ -49,14 +47,3 @@ private fun MethodInfo.isOverrideInHierarchyOf(classInfo: ClassInfo): Boolean {
 
     return false
 }
-
-fun MethodInfo.mapToRegisteredConstructor(settings: Settings): RegisteredConstructor {
-    val parameters = parameterInfo.map { it.mapToValueParameter(settings) }
-    return RegisteredConstructor(
-        fqName = fqdn,
-        parameters = parameters,
-        annotations = annotationInfo
-            .mapNotNull { it.mapToGodotAnnotation(settings) as? ConstructorAnnotation },
-        symbolProcessorSource = this
-    )
-}

kt/entry-generation/godot-entry-generator/src/main/kotlin/godot/entrygenerator/EntryGenerator.kt

@@ -1,6 +1,5 @@
 package godot.entrygenerator
 
-import godot.entrygenerator.checks.DefaultConstructorCheck
 import godot.entrygenerator.checks.FunctionArgCountCheck
 import godot.entrygenerator.checks.LateinitPropertyCheck
 import godot.entrygenerator.checks.NullablePropertyCheck
@@ -190,8 +189,6 @@ object EntryGenerator {
         registeredClasses: List<RegisteredClass>
     ): Boolean {
         return listOf(
-            DefaultConstructorCheck(logger, registeredClasses).execute(),
-
             FunctionArgCountCheck(logger, registeredClasses).execute(),
 
             SignalTypeCheck(logger, registeredClasses).execute(),

kt/entry-generation/godot-entry-generator/src/main/kotlin/godot/entrygenerator/checks/DefaultConstructorCheck.kt

@@ -96,7 +96,7 @@ class ClassRegistrarFileBuilder(
         )
 
         if (!registeredClass.isAbstract) {
-            ConstructorRegistrationGenerator.generate(registeredClass, className, registerClassControlFlow)
+            ConstructorRegistrationGenerator.generate(className, registerClassControlFlow)
             FunctionRegistrationGenerator.generate(registeredClass, className, registerClassControlFlow)
             SignalRegistrationGenerator.generate(registeredClass, className, registerClassControlFlow)
             PropertyRegistrationGenerator.generate(registeredClass, className, registerClassControlFlow)

kt/entry-generation/godot-entry-generator/src/main/kotlin/godot/entrygenerator/filebuilder/ClassRegistrarFileBuilder.kt

@@ -2,51 +2,15 @@ package godot.entrygenerator.generator
 
 import com.squareup.kotlinpoet.ClassName
 import com.squareup.kotlinpoet.FunSpec
-import godot.entrygenerator.ext.toKtVariantType
-import godot.entrygenerator.model.RegisteredClass
 import godot.tools.common.constants.godotCorePackage
 
 object ConstructorRegistrationGenerator {
 
-    fun generate(registeredClass: RegisteredClass, className: ClassName, registerClassControlFlow: FunSpec.Builder) {
-        registeredClass
-            .constructors
-            .filter { registeredConstructor ->
-                registeredConstructor.parameters.isEmpty()
-            }
-            .forEach { registeredConstructor ->
-                val ctorParamsCount = registeredConstructor.parameters.size
-
-                if (ctorParamsCount == 0) {
-                    registerClassControlFlow.addStatement(
-                        "constructor(%T(::%T))",
-                        ClassName(godotCorePackage, "KtConstructor$ctorParamsCount"),
-                        className
-                    )
-                } else {
-                    val templateArgs = mutableListOf<Any>()
-                    val templateString = buildString {
-                        append("::%T")
-                        templateArgs.add(className)
-
-                        append(",·")
-
-                        registeredConstructor.parameters.forEachIndexed { index, valueParameter ->
-                            append("%T")
-                            templateArgs.add(valueParameter.type.toKtVariantType())
-
-                            if (index != registeredConstructor.parameters.size - 1) {
-                                append(",·")
-                            }
-                        }
-                    }
-
-                    registerClassControlFlow.addStatement(
-                        "constructor(%T($templateString))",
-                        ClassName(godotCorePackage, "KtConstructor$ctorParamsCount"),
-                        *templateArgs.toTypedArray()
-                    )
-                }
-            }
+    fun generate(className: ClassName, registerClassControlFlow: FunSpec.Builder) {
+        registerClassControlFlow.addStatement(
+            "constructor(%T(::%T))",
+            ClassName(godotCorePackage, "KtConstructor"),
+            className
+        )
     }
 }

kt/entry-generation/godot-entry-generator/src/main/kotlin/godot/entrygenerator/generator/ConstructorRegistrationGenerator.kt

@@ -8,7 +8,6 @@ data class RegisteredClass(
     override val fqName: String,
     override val supertypes: List<Clazz>,
     override val annotations: List<ClassAnnotation> = emptyList(),
-    val constructors: List<RegisteredConstructor> = emptyList(),
     val functions: List<RegisteredFunction> = emptyList(),
     val signals: List<RegisteredSignal> = emptyList(),
     val properties: List<RegisteredProperty> = emptyList(),

kt/entry-generation/godot-entry-generator/src/main/kotlin/godot/entrygenerator/model/RegisteredClass.kt

@@ -2,7 +2,6 @@ package godot.entrygenerator.model
 
 data class RegisteredConstructor(
     val fqName: String,
-    val parameters: List<ValueParameter> = emptyList(),
     val annotations: List<ConstructorAnnotation> = emptyList(),
     override val symbolProcessorSource: Any
 ) : GodotJvmSourceElement