enh: fail on errors at the end of classgraph process

Author: piiertho

kt/entry-generation/godot-class-graph-symbol-processor/src/main/kotlin/godot/annotation/processor/classgraph/ErrorsDatabase.kt

@@ -0,0 +1,8 @@
+package godot.annotation.processor.classgraph
+
+object ErrorsDatabase {
+    val errors = mutableListOf<String>()
+
+    fun add(error: String) = errors.add(error)
+    fun isEmpty() = errors.isEmpty()
+}

kt/entry-generation/godot-class-graph-symbol-processor/src/main/kotlin/godot/annotation/processor/classgraph/extensions/AnnotationExtensions.kt

@@ -18,6 +18,7 @@ import godot.annotation.Sync
 import godot.annotation.Tool
 import godot.annotation.TransferMode
 import godot.annotation.processor.classgraph.Context
+import godot.annotation.processor.classgraph.ErrorsDatabase
 import godot.annotation.processor.classgraph.constants.SET
 import godot.entrygenerator.model.ColorNoAlphaHintAnnotation
 import godot.entrygenerator.model.DirHintAnnotation
@@ -64,16 +65,22 @@ fun AnnotationInfo.mapToGodotAnnotation(parentDeclaration: Any): GodotAnnotation
         )
         "godot.annotation.GodotBaseType" -> GodotBaseTypeAnnotation(this) // is internal
         EnumFlag::class.java.name -> {
-            require(parentDeclaration is FieldInfo) {
-                "EnumFlag annotation should be placed on property."
+            if (parentDeclaration !is FieldInfo) {
+                ErrorsDatabase.add(
+                    "EnumFlag annotation should be placed on property."
+                )
+                return EnumFlagHintStringAnnotation(enumValueNames = listOf(), source = this)
             }
 
             val typeDescriptor = parentDeclaration.typeSignature
 
             require(typeDescriptor is ClassRefTypeSignature)
 
-            require(typeDescriptor.fullyQualifiedClassName == SET) {
-                "Property annotated with EnumFlag should be of type $SET"
+            if (typeDescriptor.fullyQualifiedClassName != SET) {
+                ErrorsDatabase.add(
+                    "Property annotated with EnumFlag should be of type $SET"
+                )
+                return EnumFlagHintStringAnnotation(enumValueNames = listOf(), source = this)
             }
 
             val typeArgument = typeDescriptor.typeArguments.first().typeSignature as ClassRefTypeSignature

kt/entry-generation/godot-class-graph-symbol-processor/src/main/kotlin/godot/annotation/processor/classgraph/extensions/ClassExtentions.kt

@@ -4,6 +4,7 @@ import godot.annotation.RegisterClass
 import godot.annotation.RegisterFunction
 import godot.annotation.RegisterProperty
 import godot.annotation.RegisterSignal
+import godot.annotation.processor.classgraph.ErrorsDatabase
 import godot.annotation.processor.classgraph.Settings
 import godot.annotation.processor.classgraph.constants.KOTLIN_ANY
 import godot.core.KtObject
@@ -44,8 +45,10 @@ fun ClassInfo.mapToClazz(settings: Settings): Clazz {
     val shouldBeRegistered = shouldBeRegistered(methods, fields, signals)
 
     return if (shouldBeRegistered) {
-        require(constructorInfo.any { it.isPublic && it.parameterInfo.isEmpty() }) {
-            "You should provide a default constructor for class $fqName"
+        if (!constructorInfo.any { it.isPublic && it.parameterInfo.isEmpty() }) {
+            ErrorsDatabase.add(
+                "You should provide a default constructor for class $fqName"
+            )
         }
 
         RegisteredClass(

kt/entry-generation/godot-class-graph-symbol-processor/src/main/kotlin/godot/annotation/processor/classgraph/process.kt

@@ -40,6 +40,14 @@ fun generateEntryUsingClassGraph(
                     classInfo.mapToClazz(settings)
                 }
 
+            require(ErrorsDatabase.isEmpty()) {
+                buildString {
+                    for (error in ErrorsDatabase.errors) {
+                        appendLine(error)
+                    }
+                }
+            }
+
             val registeredClasses = classes.filterIsInstance<RegisteredClass>().distinctBy { clazz -> clazz.fqName }
 
             RegisteredClassMetadataContainerDatabase.populateCurrentProject(registeredClasses, settings)

kt/plugins/godot-gradle-plugin/src/main/kotlin/godot/gradle/tasks/classGraphSymbolsProcess.kt

@@ -31,11 +31,11 @@ fun Project.classGraphSymbolsProcess(
 
                 generateEntryUsingClassGraph(
                     Settings(
-                        godotJvmExtension.classPrefix.orNull,
-                        godotJvmExtension.isFqNameRegistrationEnabled.get(),
-                        (godotJvmExtension.projectName.orNull ?: project.name).replace(" ", "_"),
-                        File(projectDir.absolutePath.replace(File.separator, "/")),
-                        (
+                        classPrefix = godotJvmExtension.classPrefix.orNull,
+                        isFqNameRegistrationEnabled = godotJvmExtension.isFqNameRegistrationEnabled.get(),
+                        projectName = (godotJvmExtension.projectName.orNull ?: project.name).replace(" ", "_"),
+                        projectBaseDir = File(projectDir.absolutePath.replace(File.separator, "/")),
+                        registrationBaseDirPathRelativeToProjectDir = (
                             godotJvmExtension
                                 .registrationFileBaseDir
                                 .orNull
@@ -53,9 +53,9 @@ fun Project.classGraphSymbolsProcess(
                             .replace(File.separator, "/")
                             .removePrefix("/")
                             .removeSuffix("/"),
-                        godotJvmExtension.isRegistrationFileHierarchyEnabled.get(),
-                        godotJvmExtension.isRegistrationFileGenerationEnabled.getOrElse(true),
-                        layout.buildDirectory.get()
+                        isRegistrationFileHierarchyEnabled = godotJvmExtension.isRegistrationFileHierarchyEnabled.get(),
+                        isRegistrationFileGenerationEnabled = godotJvmExtension.isRegistrationFileGenerationEnabled.getOrElse(true),
+                        generatedSourceRootDir = layout.buildDirectory.get()
                             .asFile
                             .resolve("generated")
                             .resolve("classgraph")

kt/plugins/godot-gradle-plugin/src/main/kotlin/godot/gradle/tasks/setupBuildTask.kt

@@ -28,8 +28,7 @@ fun Project.setupBuildTask(
             task.finalizedBy(
                 copyJarTask,
                 packageBootstrapJarTask,
-                packageMainJarTask,
-//                packageMainJarWithClassGraph
+                packageMainJarTask
             )
 
             if (godotJvmExtension.isAndroidExportEnabled.get()) {