Move from KSP to classgraph for registration code and initial Scala support #761

piiertho · 2025-03-04T08:28:00Z

This moves from KSP to classgraph to generate registration code.
This also adds initial Scala support to the module.

edit by @chippmann: resolves #773

chippmann

Please also update the documentation accordingly.
Scala should at least be mentioned like java.
IMO we can add the scala specifics later in a separate PR but it is likely that this will be merged and released before that has happened. So I'd at least mention it.

Also: why not directly deleting the ksp implementation with this PR? currently there is no fallback where the user can fallback to the old symbol processor so i see no point in keeping that code around any longer.

...sor/src/main/kotlin/godot/annotation/processor/classgraph/extensions/AnnotationExtensions.kt

...sor/src/main/kotlin/godot/annotation/processor/classgraph/extensions/ClassMemberExtension.kt

...ns/godot-gradle-plugin/src/main/kotlin/godot/gradle/projectExt/configureThirdPartyPlugins.kt

...-gradle-plugin/src/main/kotlin/godot/gradle/projectExt/setupConfigurationsAndCompilations.kt

kt/plugins/godot-gradle-plugin/src/main/kotlin/godot/gradle/tasks/classGraphSymbolsProcess.kt

.../godot-gradle-plugin/src/main/kotlin/godot/gradle/tasks/initialKotlinCompileForClassGraph.kt

...s/godot-gradle-plugin/src/main/kotlin/godot/gradle/tasks/initialScalaCompileForClassGraph.kt

kt/plugins/godot-gradle-plugin/src/main/kotlin/godot/gradle/tasks/setupBuildTask.kt

src/script/jvm_script.cpp

docs/src/doc/user-guide/signals_and_callables.md

...sor/src/main/kotlin/godot/annotation/processor/classgraph/extensions/AnnotationExtensions.kt

...rocessor/src/main/kotlin/godot/annotation/processor/classgraph/extensions/ClassExtentions.kt

chippmann

Very nice work!

I would not merge this in master though atm. This together with other big upcoming changes makes it harder to create bugfix releases in the meantime until these bigger tasks are finished.
Hence i propose to reintroduce a develop branch until these bigger changes are done.

CedNaru

Took the liberty to create a develop branch and redirected the PR to it.
Otherwise, looks good to me for a first version. We'll see for more vicious potential bugs once we start using it for real.
I would also delete the ksp processor directory, but it can be done at a later point.

…nt and simplify constructor registration so we get rid of nullable info need

…rst steps in scala support

…on code

…ording to this modification

…ll test

…on doc

piiertho requested review from chippmann and CedNaru March 4, 2025 08:28

piiertho self-assigned this Mar 4, 2025

piiertho force-pushed the feature/classgraph-registration branch 2 times, most recently from 94d7905 to 249620c Compare March 5, 2025 06:52

piiertho marked this pull request as ready for review March 5, 2025 08:55

chippmann requested changes Mar 5, 2025

View reviewed changes

This was referenced Mar 10, 2025

Refine registration annotation handling #727

Open

Abstract class registration #736

Draft

piiertho force-pushed the feature/classgraph-registration branch from 679e85f to e6456df Compare March 12, 2025 03:59

chippmann requested changes Mar 12, 2025

View reviewed changes

CedNaru mentioned this pull request Mar 14, 2025

Type aliases aren't unwrapped when processing property, function, and signal registrations #773

Open

CedNaru mentioned this pull request Apr 9, 2025

:kspKotlin task randomly starts failing with "Storage for [.../id-to-file.tab] is already registered" #753

Closed

piiertho requested a review from chippmann April 16, 2025 06:39

piiertho force-pushed the feature/classgraph-registration branch from 00b28fc to 5688880 Compare April 16, 2025 07:37

chippmann approved these changes Apr 21, 2025

View reviewed changes

CedNaru changed the base branch from master to develop April 22, 2025 15:57

CedNaru approved these changes Apr 22, 2025

View reviewed changes

piiertho and others added 12 commits April 22, 2025 18:05

feat: Add java and kotlin parser to get fqdn from source code

ac70c66

feat: remove script source file path from KtClass and registration.

f5152c5

Remove lazy for named scripts

66c0a3d

feat: First draft of ClassGraph symbol processor

1738c8b

enh(entry-gen): Disallow multiple constructors with same argument cou…

9bac0d0

…nt and simplify constructor registration so we get rid of nullable info need

feat(entry-gen): Manage type parameters with classgraph

e5cf4e2

feat(classgraph): get signal parameter names from annotation

27c7d31

feat(classgraph): generate registrars using classgraph

7471d90

feat: configure gradle plugin to use classgraph instead of KSP and fi…

e5cf682

…rst steps in scala support

fix: remove gdj generation for abstract classes

6e46220

feat: Add update of gdj files

f0714dc

feat: Add support of scala source script in engine

b264e81

piiertho and others added 20 commits April 22, 2025 18:10

fix: remove deprecated context receivers in classgraph generator

35b8792

feat: set scala version configurable from gradle plugin

7b95ac8

chore: remove classes to test parser

6c2601e

fix: Add export of scala source scripts in export plugin

314af4c

fix: remove warning in source parser when no registered class found

061873e

fix: Add initial compile java task for classgraph generation

4c7a97f

fix: set right classgraph classpath for registration files generation

ff794ee

fix: Adapt code to changes from fce31d9

2bc1d68

fix: classgraph rpc enum values are now correctly set into registrati…

d595e9b

…on code

Remove support for registering constructors with arguments

70beb04

feat: Remove multi args constructor constraints and simplify code acc…

f786c38

…ording to this modification

chore: update scala implementation code to godot 4.4 and add scala ca…

903911a

…ll test

chore: rename fqdn to fqName

b89e0d9

fix: remove afterEvaluate in setupConfigurationsAndCompilations

86f5ab7

enh: fail on errors at the end of classgraph process

4e207b7

fix: remove changes on JvmScript::get_base_script

7f3b0b5

doc: Add scala support to documentation

fd6c3d0

fix(doc): java mention in scala code blocks and update entry generati…

4ff8985

…on doc

enh: Add context on classgraph errors

a905134

chore: regenerate api with godot kotlin json

a5bbd42

piiertho force-pushed the feature/classgraph-registration branch from 5688880 to a5bbd42 Compare April 22, 2025 16:10

piiertho merged commit 413eeb1 into develop Apr 23, 2025
64 checks passed

piiertho deleted the feature/classgraph-registration branch April 23, 2025 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move from KSP to classgraph for registration code and initial Scala support #761

Move from KSP to classgraph for registration code and initial Scala support #761

piiertho commented Mar 4, 2025 •

edited by chippmann

Loading

chippmann left a comment

chippmann left a comment

CedNaru left a comment

Move from KSP to classgraph for registration code and initial Scala support #761

Move from KSP to classgraph for registration code and initial Scala support #761

Conversation

piiertho commented Mar 4, 2025 • edited by chippmann Loading

chippmann left a comment

Choose a reason for hiding this comment

chippmann left a comment

Choose a reason for hiding this comment

CedNaru left a comment

Choose a reason for hiding this comment

piiertho commented Mar 4, 2025 •

edited by chippmann

Loading