Skip to content

Install dependencies before building on Linux #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

signalno11
Copy link

Fixes #827

signalno11 added 5 commits May 8, 2025 23:55
Snake case is ssssssuperior
Yes I am hastily doing this on my phone
So, there is nothing to explain
Okay, apt is doing the heavy lifting with the "check" here
@CedNaru CedNaru requested review from chippmann and piiertho May 9, 2025 16:41
@CedNaru
Copy link
Member

CedNaru commented May 9, 2025

You are adding a lot of dependency, but in Godot's own CI I only see this single install:
https://github.com/godotengine/godot/blob/19bb18716ef08b811fec330cba4d35fbdb027bcc/.github/workflows/linux_builds.yml#L111

Is there a reason for the extra stuff ? Hard Disk space is really limited in runner and we already ran into issues with it more than once. We shouldn't bloat it with so many libs if we are not sure to use them.

Remove excess dependencies
@signalno11
Copy link
Author

The instructions seem to be very different depending on the distro but these should be good. I think its a good idea just to make sure libalsa and libpulse are installed, so I left those, and the wayland and udev dev files. (Sidenote: we should probably be building with udev=yes)

@CedNaru
Copy link
Member

CedNaru commented May 9, 2025

@signalno11
Copy link
Author

Alright. The dependency is probably still smart to install, but if we haven't seen any other issues with the build yet, I suppose it's safe to simply just install wayland-devel.

@CedNaru CedNaru self-requested a review May 11, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GH Actions builds without Wayland
2 participants