More sanitization on the saving compression logic.

uvcat7 · uvcat7 · commit b3e14e149485 · 2025-07-10T09:52:32.000-07:00
diff --git a/src/Simfile/SaveSm.cpp b/src/Simfile/SaveSm.cpp
@@ -480,10 +480,12 @@ static bool GetSectionCompression(const char* section, int width, std::list<uint
 	int lcm = 1;
 	for (it = quantVec.begin(); it != quantVec.end(); it++)
 	{
-		if (*it <= 0)
+		if (*it <= 0 || *it > 192)
 		{
+			// If there's a quantization error assume nothing
 			error = true;
-			continue;
+			lcm = ROWS_PER_NOTE_SECTION;
+			break;
 		}
 		lcm = lcm * *it / gcd(lcm, *it);
 		if (lcm > ROWS_PER_NOTE_SECTION)

Original file line number	Diff line number	Diff line change
`@@ -480,10 +480,12 @@ static bool GetSectionCompression(const char* section, int width, std::list<uint`
`480`	`480`	`int lcm = 1;`
`481`	`481`	`for (it = quantVec.begin(); it != quantVec.end(); it++)`
`482`	`482`	`{`
`483`		`- if (*it <= 0)`
	`483`	`+ if (it <= 0 \|\| it > 192)`
`484`	`484`	`{`
	`485`	`+ // If there's a quantization error assume nothing`
`485`	`486`	`error = true;`
`486`		`- continue;`
	`487`	`+ lcm = ROWS_PER_NOTE_SECTION;`
	`488`	`+ break;`
`487`	`489`	`}`
`488`	`490`	`lcm = lcm * it / gcd(lcm, it);`
`489`	`491`	`if (lcm > ROWS_PER_NOTE_SECTION)`