Replace all typedefs with standard types #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the following typedefs from Core.h, so that only standard types are used: typedef uint64_t ulong typedef uint32_t uint typedef uint16_t ushort typedef uint8_t uchar typedef uint32_t color32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the following typedefs from Core.h, so that only standard types are used:
typedef uint64_t ulong
typedef uint32_t uint
typedef uint16_t ushort
typedef uint8_t uchar
typedef uint32_t color32
Also the Windows macro UINT is used in the code base so it just makes things a bit cleaner to explicitly use uint32_t instead of lowercase uint.
Note I don't find much value in the color32 typedef (I prefer knowing it's a 32 bit unsigned), but if others prefer it being color32, I don't feel super strongly about it.