Improve stability of MP3 loading #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update for branch rename
- Receptor Position - Zoom Level - Scale Level
Add some links back in.
Switching to unique_ptr / make_unique manages the lifetime of the object automatically and also handles cleanup automatically. Addresses a common crash when loading MP3 via drag and drop.
sukibaby
force-pushed
the
sukibaby-patch-mp3load
branch
from
10f4dae to
8ec05f9
Compare
|
This still crashes if you drag multiple MP3 files into the editor at once. |
|
I fixed the crash that was happening on my version. It happens more often with higher FPS (so turn your vsync off to test), and won't happen at all with multithreading disabled. |
|
It seems to work just as well here, so I'll approve it. Fwiw regarding the FPS thing, I typically use AV on a 60hz monitor, but I have a 165 and a 180hz monitor as well. In the future I'll be sure to test changes on both the higher refresh rate monitors. |
|
FWIW this seems to have been most common on mp3 because the editor converts to .ogg internally which takes a second |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to unique_ptr / make_unique manages the lifetime of the object automatically and also handles cleanup automatically. Addresses a common crash when loading MP3 via drag and drop.