Pull 1.0.1 changes into beta branch #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching to unique_ptr / make_unique manages the lifetime of the object automatically and also handles cleanup automatically. Addresses a common crash when loading MP3 via drag and drop.
…nd added failsafe mechanisms to prevent data loss.
Fix thread concurrency crash on loading MP3 audio.
The proposed implementation is more correct, and resolves bugs where certain types of valid wav files (such as 16 bit 48khz) would be considered invalid by AV.
Fix wav format compliance
…ortex into custom-snap-bounds
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Fix for code scanning alert: Workflow does not contain permissions Thanks for the catch!
Erg, thanks.
Dependabot configuration to update actions in workflow
We're out, so no need for this anymore.
Do not try to upload to Delta VPS anymore
Fix bugs with loading/saving holds, save .sm to 6 decimals, custom snap improvements
- Fixes data loss issue on loading/stepping holds/inconsistent chart saving - Correct custom quantization support for holds/rolls - Zoom settings are saved between AV sessions - Fixes crash on loading MP3 files - WAV files now load correctly - Files now save floats to 6 decimal places - Custom snaps now require a minimum snap of 5 and default to 20 if none is specified in settings.txt - Various CI improvements - CD Title search now will look for "title"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.