Google style guide enforcing #150
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the following typedefs from Core.h, so that only standard types are used: typedef uint64_t ulong typedef uint32_t uint typedef uint16_t ushort typedef uint8_t uchar typedef uint32_t color32
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: uvcat7 <152119638+uvcat7@users.noreply.github.com>
* Upload bin/ directory as artifact * Apply suggestion from @ScottBrenner --------- Co-authored-by: uvcat7 <152119638+uvcat7@users.noreply.github.com>
Configures CodeQL scanning for the repository.
Wouldn't be shown when both ends were off screen, unlike reverse scroll.
Credits: - @poco0317 made the PR. - @nobbele reviewed the PR and fixed a regression in WAV loading. - @sukibaby resolved merge conflicts and refactored MP3 loading following changes to std::filesystem. Squashed commit history is as follows: * Remove String and StringRef (poco0317) this doesnt compile. effectively a replacement of: String -> std::string StringRef -> const std::string& * Fix compilation issues after removing String/StringRef (poco0317) this includes some questionable includes of Core.h which seemed to be required to compile. this also includes some reimplementations of StringUtils functions and misc items * String removal crash fix 1 (poco0317) * String removal broken format string fix (poco0317) * finish merge (poco0317) * String removal crash fix 2 (poco0317) i was getting cant reference iterator past end over and over here for no reason no matter what i did even if i checked for end and then ran into 25 other errors so lets just rewrite it * String removal warns reduction (poco0317) this doesnt solve as many as i would like but it begins to reach outside the scope as more get fixed. it would be more ideal to actually just change the argument types instead of doing all this casting * String removal - for shader logging, clear and resize a string (poco0317) * String removal - Str::create replaced by constructor (poco0317) template <class InputIterator> std::string (InputIterator first, InputIterator last); * String removal - remove Str::assign (poco0317) * String removal crash fix 3 (poco0317) typo * String removal - replace stricmp (poco0317) * String removal - fix weird char to str cast (poco0317) * Correctly calculate frame counts when reading WAV files (nobbele) * fixes (sukibaby) resolve merge conflicts, make it build again * mp3 loader fix (sukibaby) --------- Co-authored-by: nobbele <realnobbele@gmail.com> Co-authored-by: sukibaby <163092272+sukibaby@users.noreply.github.com>
a small amount of this was not actually directly involved in the String removal, but are necessary based on the changes to the Str functions. it would actually be better to remove some of the Str functions. but that would require effort
Fixes the File.cpp changes that were broken in uvcat7#132 (and broken again in uvcat7#135).
Path-constructed fstream sets the failbit when the file can't be loaded. Closes uvcat7#144
* set cpp20 in the vcxproj * add missing algorithm header * resolve Aubio compilation * fix new_aubio_specdesc * add discardedField to loading editor ticks * fix myClassName const-ness in SystemImpl * fix const-ness for Debug MessageBox * simplify music changes * resolve PR comment * change SystemImpl::myClassName to LPCWSTR * switch hardcoded strings in new_aubio_window to aubio_window_type * separate emptyString into placeholders * add C++20 to other configurations as well --------- Co-authored-by: a <a@a>
|
oops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #148