-
Notifications
You must be signed in to change notification settings - Fork 21
Clang errors #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang errors #188
Conversation
I manually fixed another 200 or so warnings by hand. Pretty sure I got them all, but it'd be great if someone could verify. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no warnings on my machine
consider escalating warnings to errors in the clang-tidy config to force devs to check stuff like this
as in
also doublecheck if this does actually work in VS (e.g. do a C style cast somewhere and await the Armageddon) |
I'll add the clang-tidy enforcement in my next PR! |
I used the -fix argument on clang-tidy to squash the hundreds of warnings that our style guide was creating on build.
Think it's fine.