Skip to content

Conversation

uvcat7
Copy link
Owner

@uvcat7 uvcat7 commented Aug 17, 2025

I used the -fix argument on clang-tidy to squash the hundreds of warnings that our style guide was creating on build.
Think it's fine.

@uvcat7 uvcat7 requested a review from convextriangle August 17, 2025 21:37
@uvcat7
Copy link
Owner Author

uvcat7 commented Aug 21, 2025

I manually fixed another 200 or so warnings by hand. Pretty sure I got them all, but it'd be great if someone could verify.

Copy link
Collaborator

@convextriangle convextriangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no warnings on my machine
consider escalating warnings to errors in the clang-tidy config to force devs to check stuff like this

@convextriangle
Copy link
Collaborator

convextriangle commented Aug 21, 2025

no warnings on my machine consider escalating warnings to errors in the clang-tidy config to force devs to check stuff like this

as in .clang-tidy:

WarningsAsErrors: '*'

also doublecheck if this does actually work in VS (e.g. do a C style cast somewhere and await the Armageddon)

@uvcat7
Copy link
Owner Author

uvcat7 commented Aug 23, 2025

I'll add the clang-tidy enforcement in my next PR!

@uvcat7 uvcat7 merged commit 90f2495 into beta Aug 23, 2025
5 checks passed
@uvcat7 uvcat7 deleted the clang-errors branch August 23, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants