-
Notifications
You must be signed in to change notification settings - Fork 21
CMake pt.2: Electric Boogaloo #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sukibaby, are you still having issues with this? Looks like it's working for me. |
f1ce373
to
8b29c8e
Compare
Now it's fully migrated to vcpkg&CMake, including CI \o/ Another nice thing to have is binary cache for CI, but I don't have enough permissions for that, instructions for it can be found at https://learn.microsoft.com/en-us/vcpkg/users/binarycaching |
5b755b7
to
03a2260
Compare
6e987f4
to
92b4414
Compare
FWIW currently there's a regression from File.cpp changes which revealed a bug in how executable is launched, so this shouldn't be merged for now |
Reminder to myself that C++ 20 needs to be enabled before merging but after rebase. |
What's the issue? |
|
merge mistake, will need to be force pushed over likely |
da8e688
to
48651f7
Compare
3b2bdb3
to
97b2ed9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I have NO idea what you changed to solve the problem but this finally seems to work correctly from a fresh copy of the source code.
The build information to fix the freetype issue should be good enough if this happens in the future, but I really hope it doesn't.
8a666b4
to
04a96b4
Compare
Will be used for CMake builds on Windows, unlikely to be used on Linux.
This seems to be the default dir for build artifacts in Visual Studio with CMake.
This way Visual Studio will build static binaries by default.
ArrowVortex needs files from bin/{assets/,noetskins/,settings/} to be located right next to executable, otherwise UI will appear to be broken. This also adds another target to Visual Studio, so that ArrowVortex.exe doesn't need to be copied each time to bin/.
This way there's no need to run install target, which clears up some confusion. Closes #25
Restores debug console in debug builds with CMake. Continuation of work started in initial CMake migration commit. Both CMake and Visual Studio define this variable during debug builds, it's used in <cassert> and was used in some places before migration.
VS-specific file containing various configurations. This one is initialized with Debug and Release configurations.
Update the build information
04a96b4
to
6683ce7
Compare
No description provided.