Skip to content

Conversation

DolphinChips
Copy link
Collaborator

@DolphinChips DolphinChips commented Jun 12, 2025

No description provided.

@uvcat7
Copy link
Owner

uvcat7 commented Jul 9, 2025

@sukibaby, are you still having issues with this? Looks like it's working for me.

@DolphinChips DolphinChips force-pushed the cmake-only branch 7 times, most recently from f1ce373 to 8b29c8e Compare July 10, 2025 13:23
@DolphinChips DolphinChips changed the title Draft: CMake pt.2: Electric Boogaloo CMake pt.2: Electric Boogaloo Jul 10, 2025
@DolphinChips
Copy link
Collaborator Author

Now it's fully migrated to vcpkg&CMake, including CI \o/ Another nice thing to have is binary cache for CI, but I don't have enough permissions for that, instructions for it can be found at https://learn.microsoft.com/en-us/vcpkg/users/binarycaching

@DolphinChips DolphinChips force-pushed the cmake-only branch 5 times, most recently from 5b755b7 to 03a2260 Compare July 14, 2025 19:44
@DolphinChips DolphinChips force-pushed the cmake-only branch 3 times, most recently from 6e987f4 to 92b4414 Compare July 15, 2025 04:21
@DolphinChips
Copy link
Collaborator Author

FWIW currently there's a regression from File.cpp changes which revealed a bug in how executable is launched, so this shouldn't be merged for now

@uvcat7
Copy link
Owner

uvcat7 commented Jul 20, 2025

Reminder to myself that C++ 20 needs to be enabled before merging but after rebase.

@nobbele
Copy link
Collaborator

nobbele commented Jul 20, 2025

FWIW currently there's a regression from File.cpp changes which revealed a bug in how executable is launched, so this shouldn't be merged for now

What's the issue?

@DolphinChips
Copy link
Collaborator Author

FWIW currently there's a regression from File.cpp changes which revealed a bug in how executable is launched, so this shouldn't be merged for now

What's the issue?

#144

@convextriangle
Copy link
Collaborator

FWIW currently there's a regression from File.cpp changes which revealed a bug in how executable is launched, so this shouldn't be merged for now

What's the issue?

#144

it should have been resolved in #145 - are there any other blockers for merging this?

@convextriangle
Copy link
Collaborator

merge mistake, will need to be force pushed over likely
my bad

@DolphinChips DolphinChips force-pushed the cmake-only branch 2 times, most recently from da8e688 to 48651f7 Compare July 31, 2025 10:34
Copy link
Owner

@uvcat7 uvcat7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I have NO idea what you changed to solve the problem but this finally seems to work correctly from a fresh copy of the source code.

The build information to fix the freetype issue should be good enough if this happens in the future, but I really hope it doesn't.

DolphinChips and others added 14 commits August 9, 2025 10:10
Will be used for CMake builds on Windows, unlikely to be used on
Linux.
This seems to be the default dir for build artifacts in Visual
Studio with CMake.
This way Visual Studio will build static binaries by default.
ArrowVortex needs files from bin/{assets/,noetskins/,settings/} to be
located right next to executable, otherwise UI will appear to be broken.
This also adds another target to Visual Studio, so that ArrowVortex.exe
doesn't need to be copied each time to bin/.
This way there's no need to run install target, which clears up
some confusion. Closes #25
Restores debug console in debug builds with CMake. Continuation of
work started in initial CMake migration commit. Both CMake and
Visual Studio define this variable during debug builds, it's used
in <cassert> and was used in some places before migration.
VS-specific file containing various configurations. This one is
initialized with Debug and Release configurations.
Update the build information
@uvcat7 uvcat7 merged commit b349027 into beta Aug 9, 2025
5 checks passed
@uvcat7 uvcat7 deleted the cmake-only branch August 9, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants