Skip to content

Improve interoperability of task arenas and task groups #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 1, 2025
Merged

Improve interoperability of task arenas and task groups #624

merged 3 commits into from
Aug 1, 2025

Conversation

akukanov
Copy link
Contributor

@akukanov akukanov commented May 9, 2025

The patch proposes additions to the class task_arena and the namespace this_task_arena to interoperate with task_group: new overloads for enqueue which additionally take a task_group argument, and the new wait_for method that also takes a task_group.

Design details can be found in https://github.com/uxlfoundation/oneTBB/blob/master/rfcs/proposed/task_arena_waiting/task_group_interop.md

@akukanov akukanov added the TBB label May 9, 2025
@omalyshe omalyshe requested a review from aepanchi May 9, 2025 13:21
@akukanov akukanov requested a review from isaevil July 8, 2025 16:32
@isaevil isaevil mentioned this pull request Jul 17, 2025
Open
13 tasks
isaevil
isaevil approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@isaevil isaevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

aleksei-fedotov
aleksei-fedotov approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@aleksei-fedotov aleksei-fedotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@akukanov akukanov removed the request for review from aepanchi July 29, 2025 18:54
omalyshe
omalyshe reviewed Jul 31, 2025
View reviewed changes
Copy link

@omalyshe omalyshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the copyright year in both files.

omalyshe
omalyshe approved these changes Jul 31, 2025
View reviewed changes
Copy link

@omalyshe omalyshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vossmjp
vossmjp approved these changes Jul 31, 2025
View reviewed changes
Copy link

@vossmjp vossmjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.

@akukanov akukanov merged commit eeba9b9 into uxlfoundation:main Aug 1, 2025
3 checks passed
@akukanov akukanov deleted the onetbb-task-arena-task-group-wait branch August 1, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksei-fedotov aleksei-fedotov aleksei-fedotov approved these changes

@vossmjp vossmjp vossmjp approved these changes

@omalyshe omalyshe omalyshe approved these changes

@isaevil isaevil isaevil approved these changes

@kboyarinov kboyarinov Awaiting requested review from kboyarinov

Assignees
No one assigned
Labels
TBB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akukanov @aleksei-fedotov @vossmjp @omalyshe @isaevil