WIP: Enable array api support in neighbor #2700

yuejiaointel · 2025-09-30T00:01:34Z

Description

Follow up PR of #2284 (will rebase after this one is merged)
that refactor neighbors with array api standard

Checklist:

Completeness and readability

I have commented my code, particularly in hard-to-understand areas.
I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
I have resolved any merge conflicts that might occur with the base branch.

Testing

I have run it locally and tested the changes extensively.
All CI jobs are green or I have provided justification why they aren't.
I have extended testing suite if new functionality was introduced in this PR.

Performance

I have measured performance for affected algorithms using scikit-learn_bench and provided at least a summary table with measured data, if performance change is expected.
I have provided justification why performance and/or quality metrics have changed or why changes are not expected.
I have extended the benchmarking suite and provided a corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

david-cortes-intel · 2025-10-07T09:10:42Z

sklearnex/neighbors/_lof.py

+
+            from onedal.utils.validation import _check_array
+
+            X = _check_array(X, accept_sparse="csr", dtype=[np.float64, np.float32])


Shouldn't it extract the namespace to get the dtypes, as done elsewhere? For example:

scikit-learn-intelex/sklearnex/linear_model/linear.py

Line 267 in 2ad6ef7

dtype=[xp.float64, xp.float32],

There are lots of parts in onedal neighbor we need to move to sklearnex, and I plan to do array api stuff after this step to avoid too much changes at once

I'd prefer to have all the changes in one PR as they'd be modifying the same parts.

sklearnex/neighbors/_lof.py

david-cortes-intel · 2025-10-10T10:05:28Z

As part of the PR, please add the relevant classes that will get array api support to this list now that they are documented:

scikit-learn-intelex/doc/sources/array_api.rst

Line 84 in 3d86aeb

Supported classes

yuejiaointel · 2025-10-21T21:04:01Z

/intelci: run

yuejiaointel · 2025-10-21T21:46:18Z

/intelci: run

yuejiaointel · 2025-10-21T22:03:45Z

/intelci: run

yuejiaointel · 2025-10-22T01:35:22Z

/intelci: run

yuejiaointel · 2025-10-22T06:51:05Z

/intelci: run

david-cortes-intel · 2025-10-22T13:42:20Z

The CI error appears to come from the changes in this PR:

File "<path>/build/onedal_linux_icx/__release_lnx/daal4py-3.9/onedal/neighbors/neighbors.py", line 137, in _fit
    raise ValueError(
ValueError: Classification target processing must be done in sklearnex layer before calling onedal fit. _y attribute is not set. This indicates the refactoring is incomplete.

Note that it occurs when using the SPMD class:

File "<path>/examples/sklearnex/knn_bf_classification_spmd.py", line 64, in <module>
    model_spmd.fit(dpt_X_train, dpt_y_train)

yuejiaointel · 2025-10-22T20:18:27Z

/intelci: run

yuejiaointel · 2025-10-22T20:26:11Z

/intelci: run

yuejiaointel · 2025-10-23T00:28:17Z

/intelci: run

yuejiaointel · 2025-10-23T04:12:27Z

/intelci: run

yuejiaointel · 2025-10-23T06:33:11Z

/intelci: run

yuejiaointel · 2025-10-23T06:38:04Z

/intelci: run

yuejiaointel · 2025-10-24T01:50:31Z

/intelci: run

yuejiaointel · 2025-10-24T06:42:13Z

/intelci: run

yuejiaointel · 2025-10-24T15:26:51Z

/intelci: run

yuejiaointel · 2025-10-24T23:15:05Z

/intelci: run

yuejiaointel · 2025-10-24T23:16:18Z

/intelci: run

icfaust mentioned this pull request Sep 30, 2025

Add NearestNeighbors SPMD API #2557

Merged

13 tasks

david-cortes-intel reviewed Oct 7, 2025

View reviewed changes

yuejiaointel added 7 commits October 7, 2025 10:55

refactor: move/delete some methods in neighbors.py

82fc26d

fix: try it again

325753c

fix: try it again

d17bb34

fix: try it again

0e8b4c6

fix: first round of refactor move preprocssing function to sklearnex

9dda937

fix: fix shape

8bd86c2

rebase: rebase to main

debfcdf

yuejiaointel force-pushed the refactor_neighbor_array_api branch from 25b3930 to debfcdf Compare October 7, 2025 18:07

yuejiaointel added 3 commits October 7, 2025 12:01

fix: add fit emthod logic in onedla

e9e7306

fix: fix test

02da9e9

fix: fix tupleerror

62c8ddd

yuejiaointel force-pushed the refactor_neighbor_array_api branch from a569e0c to 62c8ddd Compare October 9, 2025 05:33

yuejiaointel added 2 commits October 9, 2025 16:13

fix: fix tuple issue

fc296b5

print: print fit_x

fe0abbb

yuejiaointel added 13 commits October 10, 2025 11:52

fix: fixed tuple

e202e65

fix: fix tuple

649fc5d

print: print in save attributes

a1f95f1

fix: tuple handling

939a4f6

print: add print

a4b1351

print: test print

39ae6c5

test: test fix for typle

aa98829

fix: more print

2f834d0

fix: test fix for tuyple issue

dcf5b43

fix: test fix for tuyple issue

9c65647

fix: try add validation

b33834d

fix: try restore neighbors funcitons

96762db

fix: test restore

cc2293c

yuejiaointel marked this pull request as draft October 21, 2025 21:03

fix: spmd also use skelarnex neighbors

f3c949b

test: test without classes_check in onedal neighbor

db8070d

yuejiaointel force-pushed the refactor_neighbor_array_api branch from b77edd9 to db8070d Compare October 22, 2025 22:37

yuejiaointel force-pushed the refactor_neighbor_array_api branch from 3878df0 to db8070d Compare October 23, 2025 06:06

fix: spmd issue

65b160b

fix: format

231eb32

icfaust mentioned this pull request Oct 23, 2025

[maintenance] change logic in sklearnex get_namespace to follow sklearn array API expected behavior #2747

Draft

10 tasks

fix: make sure y is numeric in regrresor

64bb25e

fix: fix spmd test

9dfcb70

fix: common tests

93fcbfd

fix: spmd issues

295be53

fix: format

db1e130


		from onedal.utils.validation import _check_array

		X = _check_array(X, accept_sparse="csr", dtype=[np.float64, np.float32])

WIP: Enable array api support in neighbor #2700

Are you sure you want to change the base?

WIP: Enable array api support in neighbor #2700

Conversation

yuejiaointel commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

david-cortes-intel Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

yuejiaointel Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

david-cortes-intel Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

david-cortes-intel commented Oct 10, 2025

Uh oh!

yuejiaointel commented Oct 21, 2025

Uh oh!

yuejiaointel commented Oct 21, 2025

Uh oh!

yuejiaointel commented Oct 21, 2025

Uh oh!

yuejiaointel commented Oct 22, 2025

Uh oh!

yuejiaointel commented Oct 22, 2025

Uh oh!

david-cortes-intel commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuejiaointel commented Oct 22, 2025

Uh oh!

yuejiaointel commented Oct 22, 2025

Uh oh!

yuejiaointel commented Oct 23, 2025

Uh oh!

yuejiaointel commented Oct 23, 2025

Uh oh!

yuejiaointel commented Oct 23, 2025

Uh oh!

yuejiaointel commented Oct 23, 2025

Uh oh!

yuejiaointel commented Oct 24, 2025

Uh oh!

yuejiaointel commented Oct 24, 2025

Uh oh!

yuejiaointel commented Oct 24, 2025

Uh oh!

yuejiaointel commented Oct 24, 2025

Uh oh!

yuejiaointel commented Oct 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yuejiaointel commented Sep 30, 2025 •

edited

Loading

david-cortes-intel commented Oct 22, 2025 •

edited

Loading