MAINT: Updates for XGBoost3.1 model structures #2741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-cortes-intel
requested review from
Alexsandruss,
ahuber21,
ethanglaser,
icfaust,
razdoburdin and
yuejiaointel
as code owners
david-cortes-intel
requested review from
avolkov-intel,
homksei and
napetrov
as code owners
|
/intelci: run |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
icfaust
reviewed
Oct 21, 2025
tests/test_model_builders.py
Outdated
| xgb_model = treelite.frontend.from_xgboost(xgb_model) | ||
| try: | ||
| xgb_model = treelite.frontend.from_xgboost(xgb_model) | ||
| except Exception: |
There was a problem hiding this comment.
Any way you can catch a more specific exception here?
There was a problem hiding this comment.
It can fail in multiple ways which throw different errors, and it looks like the first error encountered here will be different in the next treelite release. It could be done, but this is just a temporary workaround that should be removed soon.
|
/intelci: run |
|
/intelci: run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the model builders from xgboost objects to be able to process multi-class classification models with the new structure introduced in version 3.1.0, which has vector-valued intercepts.
Checklist:
Completeness and readability
Testing