read env var from http conf file (bsc#1253282) #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbussolotto
force-pushed
the
proxy_env_file
branch
2 times, most recently
from
afbdcb6 to
c027db4
Compare
mbussolotto
force-pushed
the
proxy_env_file
branch
from
c027db4 to
902945b
Compare
Member
Author
|
add @aaannz as reviewer: I'm not sure if the podman bug related to quotation mark can be workaround by this PR, or if it's fine as it is. |
cbosdo
reviewed
Nov 13, 2025
mgrpxy/shared/templates/tftpd.go
Outdated
Comment on lines
43
to
44
| --env-file {{ .HTTPProxyFile }} \ | ||
| {{- end }} |
Contributor
There was a problem hiding this comment.
Same here, does it make sense on the TFTPD container?
cbosdo
force-pushed
the
proxy_env_file
branch
from
902945b to
474fa25
Compare
cbosdo
approved these changes
Nov 21, 2025
mbussolotto
force-pushed
the
proxy_env_file
branch
2 times, most recently
from
902945b to
e1e8288
Compare
cbosdo
force-pushed
the
proxy_env_file
branch
from
e1e8288 to
474fa25
Compare
cbosdo
force-pushed
the
proxy_env_file
branch
from
474fa25 to
b4a1096
Compare
|
aaannz
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
as title
It seems that EnvironmentFile can be provide just on the containers, not on the pod. I tested it manually (changing the systemd file) but not with
mgrpxyCodespace
Check if you already have a running container clicking on
Test coverage
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/28907
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!