Skip to content

Avoid adding of a batch dim on 2d signals. #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
felixblanke opened this issue Jun 24, 2024 · 1 comment
Closed

Avoid adding of a batch dim on 2d signals. #92

felixblanke opened this issue Jun 24, 2024 · 1 comment
Assignees
Labels
invalid This doesn't seem right

Comments

@felixblanke
Copy link
Collaborator

For 1d signals the coefficients as well as reconstructed signals keep the same number of dimensions as the original input signal.
However, for 2d signals with only 2 axes we currently always add a superfluous batch dimension, i.e. [H, W] -> [1, H, W].

This seems inconsistent.

We can address this by introducing a functionality similiar to ptwt.conv_transform._postprocess_result_list_dec1d for higher dimensions.

@v0lta
Copy link
Owner

v0lta commented Jul 1, 2024

#93 is merged.

@v0lta v0lta closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants