Skip to content

Make preprocessing and postprocessing consistent accross transforms #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Jul 1, 2024
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
0a1b515
Integrate axis swap into 1d processing funcs
felixblanke Jun 24, 2024
2426060
Make channel dim addition optional
felixblanke Jun 24, 2024
eaa2fb6
Refactor; Add processing funcs for 2d
felixblanke Jun 24, 2024
0e4cb27
Move processung funcs to _util module
felixblanke Jun 24, 2024
3554a53
Generalize tensor processing
felixblanke Jun 24, 2024
4e8ed02
Adapt 1d cases
felixblanke Jun 24, 2024
f889158
Extend _map_result to 1d case
felixblanke Jun 24, 2024
0ed2896
Make _preprocess_coeffs general
felixblanke Jun 24, 2024
03f74b7
Make postprocessing general
felixblanke Jun 24, 2024
ae7b345
Apply process funcs in 3d transforms
felixblanke Jun 24, 2024
21332bf
Format
felixblanke Jun 24, 2024
b461c97
Fix coeff postprocess
felixblanke Jun 24, 2024
105a0a8
Reduce tensor processing to coeff processing
felixblanke Jun 24, 2024
24a25f4
Add fully separable transforms for n dims
felixblanke Jun 24, 2024
169d6cf
Move dtype check to preprocessing
felixblanke Jun 24, 2024
ba1b83d
Encapsulate check for consistent dtype and device
felixblanke Jun 24, 2024
d50a2c2
Revert changes to coeff shape check
felixblanke Jun 24, 2024
2d4620a
Make n-dim separable trafo private
felixblanke Jun 25, 2024
1b45eae
Add explainatory comments
felixblanke Jun 25, 2024
15af78b
Add docstrings
felixblanke Jun 25, 2024
35bab80
Rename _map_result to _apply_to_tensor_elems
felixblanke Jun 25, 2024
37db5db
Format
felixblanke Jun 25, 2024
b4c16e2
rename tree_map
v0lta Jun 26, 2024
a9569f2
rename coeff tree map.
v0lta Jun 26, 2024
d1339f0
Add remark on JAX tree map
felixblanke Jun 26, 2024
6254f13
Merge branch 'main' into fix/keep-ndims-Nd
v0lta Jul 1, 2024
e281c85
merge.
v0lta Jul 1, 2024
75ad167
formatting.
v0lta Jul 1, 2024
e3fe0f4
fix typing.
v0lta Jul 1, 2024
d6d8259
Fix ndim sep trafo usage comments
felixblanke Jul 1, 2024
de1b7c8
Fix docstr
felixblanke Jul 1, 2024
986692f
nd-transforms are out of scope.
v0lta Jul 1, 2024
f008cfa
Merge branch 'fix/keep-ndims-Nd' of github.com:v0lta/PyTorch-Wavelet-…
v0lta Jul 1, 2024
77ca368
short note.
v0lta Jul 1, 2024
cef6a04
move note.
v0lta Jul 1, 2024
9981521
add note to forward and backward.
v0lta Jul 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/ptwt/separable_conv_transform.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ def _separable_conv_dwtn_(
All but the first axes are transformed.

Note:
Please note, that ND-Transforms are generally out
of this project's scope.
ND-Transforms are generally out of this project's scope.

Args:
rec_dict (WaveletDetailDict): The result will be stored here
Expand Down
Loading